[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [p2-dev] QueryUtil changes and their impact on testability

Hi Jason,
The problem with the ql bundle not being present has been resolved [1] (all functionality has been moved into the metadata bundle) so there are no longer any static references to services that are not declared in the same bundle. In fact, the need for the parser and factory services is gone so perhaps the next step would be to remove them altogether.

Can you please request this in a bugzilla?

- thomas

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=306217

On 03/23/2010 04:53 PM, Jason Barkanic wrote:
We ran into a problem here, and I would second this being a problem, but for slightly different reasons.  I don't know if it's being pedantic, but having service lookups in static initializers seems to be contrary to the service paradigm (where code should gracefully handle services not being available, or coming and going).  For instance, if the service is not available, or a non compatible service is bound and an exception occurs (which happens if the ql bundle is not provided), the class is hosed, it can't be loaded again (even if you fixed the problem and now have a service available).  You have to restart the JVM (although maybe there is some way to make the JVM forget about the exception in the initialization of a class.. but still).


On Tue, Mar 23, 2010 at 8:41 AM, Thomas Hallgren <thomas@xxxxxxx> wrote:
Hi Matt,
p2 is an OSGi based framework so when running test on it, you need to run them as "JUnit Plug-in tests". That has always been the case as far as I know. A lot of p2 relies on services being started etc.

Thomas Hallgren

On 03/23/2010 04:07 PM, Matt Hughes wrote:
Now that many of the *Query classes have moved into static methods on
QueryUtil, there is a problem with unit testability.

QueryUtil has a static initializers that use ExpressionUtil.

ExpressionUtil has static initializers that *depend on running in an
OSGi environment* (not unit test):

public final class ExpressionUtil {
       private static final LDAPFilterParser ldapFilterParser = new
       public static final IExpression TRUE_EXPRESSION =
       public static final IExpression FALSE_EXPRESSION =

       private ExpressionUtil() {
               //We don't want to ppl to instantiate this class

        * Returns the global _expression_ factory
        * @return The global _expression_ factory.
       public static IExpressionFactory getFactory() {
               return MetadataActivator.getExpressionFactory();

(As soon as one even references ExpressionUtil, its static
initializers are called which in turn invoke #getFactory which rely on
MetadataActivator to have been activated by OSGi context.)

Therefore, if any class uses QueryUtil in its implementation (which
many must do now since the *Query classes have gone away), those
classes cannot be unit tested.  One could try and get around this by
setting MetadataActivator.instance, but that would only get you so
far.  Metadata#getExpressionFactory would still fail and cannot be
stubbed out so far as I can tell.

Am I missing something?  How are people testing this code that makes
use of QueryUtil?
p2-dev mailing list

p2-dev mailing list

_______________________________________________ p2-dev mailing list p2-dev@xxxxxxxxxxx https://dev.eclipse.org/mailman/listinfo/p2-dev