[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [p2-dev] committer votes and fumbled fingers.

Agreed.  In terms of the process around this, on Mylyn we have the simple convention of using patches when you want a change in a portion of the code that would benefit from review.  In part for this reason, we’ve invested considerable time in making UI sugar in Mylyn for working with patch-based change sets in Eclipse with Bugzilla.  So you can expect that any changes to non-discovery P2 code from Steffen and Shawn will come as patches.


Incidentally, I was expecting that Shawn and Steffen would be getting commit rights only on the Discovery component of P2, since their effort will be focused there.  That’s why I thought that this was a move review just like Zest’s to GEF.  But in the end its up to the project to decide whether tighter or looser commit rights make more sense.




From: p2-dev-bounces@xxxxxxxxxxx [mailto:p2-dev-bounces@xxxxxxxxxxx] On Behalf Of John Arthorne
Sent: December-09-09 8:43 AM
To: P2 developer discussions
Subject: Re: [p2-dev] committer votes and fumbled fingers.


Ian Bull wrote on 12/09/2009 01:01:59 AM:
> I think the reaction of the "moved" committers is also interesting.
>   I wonder if a "moved" committer would have any reservation
> touching code outside of the moved code.  

I certainly hope so. I think this is normal expected behavior for committers. You may be a committer on a large component but only have interest or expertise in some small part of it. Generally committers don't make significant changes in code they are not familiar with without discussing or reviewing with the committer who "owns" or is most familiar with the particular piece of code. Note I'm not saying this needs to be enforced or written down anywhere - in all Eclipse components I have worked on this has never been a problem and various "social protocols" are used to deal with it (voice/IRC/mailing list conversations, requests for review on bugs, etc). If I'm unsure I will usually look at the CVS history of the file to see who has most recently been active in a piece of code, and ping them if I'd like to make a change that I'm not sure about.