Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [orion-dev] Webtools Roadmap Questions

Thanks John!

I'll try to separate my changes into more easily digestible chunks, but I'm not sure how easy that will be. Honestly, adding contextual and embedded content assist isn't a small change. The core relies on an HTML scanner that provides range information, something lacking from htmlparser (the scanner in WebTools, it's col + line based). And then these changes rely on a way of managing a shared DOM and a model of HTML, etc, etc.

I'll take a pass at the open bugs and see if I can contribute a few fixes as a means of getting my feet wet.

Thanks!




On Mon, Aug 18, 2014 at 5:34 PM, John Arthorne <John_Arthorne@xxxxxxxxxx> wrote:
Hi David,

1) The Eclipse foundation does IP due diligence on 3rd party libraries. I.,e check for license compatibility, code scan, provenance check, etc. This can take a few weeks, depending on the library and where it comes from. If the maintainers of the 3rd party library are responsive to questions it is usually not a problem. We are happy to use 3rd party libraries when needed, but don't adopt them casually for minor conveniences because it does add some overhead work and also carries risks when those libraries stop being maintained. Either me or another Orion committer can help guide you through this.

2) I would usually recommend starting with small contributions if possible, just to get your feet wet with the contribution process. If there is any way to split up your work into multiple discrete contributions that will make it easier to consume, unless the changes are intertwined. The best way to submit contributions is via Gerrit, although they can also be pulled from other sources such as GitHub if needed. Here is a guide to the contribution process:

https://wiki.eclipse.org/Orion/Contributing_Code

Looking forward to your contributions!

John




From:        David Zuckerman <davidz@xxxxxxx>
To:        orion-dev@xxxxxxxxxxx,
Date:        08/17/2014 07:47 AM
Subject:        Re: [orion-dev] Webtools Roadmap Questions
Sent by:        orion-dev-bounces@xxxxxxxxxxx




Hi Curtis-

Thanks for your response! Tentatively, we're interested in contributing back to the Webtools module. However, I have a few questions not covered in the contribution guide on your Wiki

1.) You mentioned IP issues around third party libraries: reading between the lines, that means no third party libraries? We're using underscore for basic data processing, but it's not vital.

2.) The size of the contributions are also not trivial, and introduce a few concepts (typedef-style definitions for HTML, ASTManager-like structure for HTML for example) that I worry may complicate things. Are there best practices for this kind of thing?

Any advice would be much appreciated.

Thanks!_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/orion-dev

_______________________________________________
orion-dev mailing list
orion-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/orion-dev



--

David Zuckerman
SDK Product Architect


Back to the top