Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[orbit-dev] EBR way of patching class from upstream JAR?

Hi Orbit developers,

to fix Bug 517935 [1], I had to come up with a patched version of the
org.apache.lucene.core 5.2.1 and 6.1.0 bundles currently in Orbit.

Here's my question:

- What's the "EBR way" to achieve this?

- What legal requirements are there when I want to do a small (one-line)
modification of an upstream bundle?

Please have a look at this change in Gerrit [2]. Is making the one-line
change directly in a copy of the upstream class OK, or should I make use
of the maven-patch-plugin [3] or similar to make explicit what my change
is and what comes straight from the upstream project.

Best wishes,

Andreas

[1] <https://bugs.eclipse.org/bugs/show_bug.cgi?id=517935>
[2] <https://git.eclipse.org/r/98804/>
[3] <https://maven.apache.org/plugins/maven-patch-plugin/>

-- 
Codetrails GmbH
The knowledge transfer company

Robert-Bosch-Str. 7, 64293 Darmstadt
Phone: +49-6151-276-7092
Mobile: +49-170-811-3791
http://www.codetrails.com/

Managing Director: Dr. Marcel Bruch
Handelsregister: Darmstadt HRB 91940

Attachment: signature.asc
Description: OpenPGP digital signature


Back to the top