Re: [orbit-dev] Bugfixing 3rd party code due to lack of a release?

[Chris Aniszczyk <zx@xxxxxxxxxx>]

My personal feelings coming from the long days of maintaining patches for java libraries in a Linux distro... Orbit shouldn't be in the business of applying patches like this.

I would either do this in order of priority
1) Build a relationship with the commons net folk to get them to publish a release. I believe Darin Swanson has done a pretty good job about this with Ant, maybe he has advice.
2) If this fails and we are truly in dire straits for Ganymede, I'd put a nightly in (http://people.apache.org/builds/commons/nightly/commons-net/) but that decision shouldn't be taken lightly.

I do respect your desire to solve this nasty user issue, but I'd hold off as long as possible in my opinion... hoping for a new commons release.

Cheers,

---
Chris Aniszczyk | IBM Lotus | Eclipse Committer | http://mea-bloga.blogspot.com | +1.860.839.2465

"Oberhuber, Martin" ---09/12/2007 07:31:07 AM---Hello, We have a major bug open that can lead to deadlocks

From:	"Oberhuber, Martin" <Martin.Oberhuber@xxxxxxxxxxxxx>
To:	"Orbit Developer discussion" <orbit-dev@xxxxxxxxxxx>, "Janet Campbell" <janet.campbell@xxxxxxxxxxx>, "Bjorn Freeman-Benson" <bjorn.freeman-benson@xxxxxxxxxxx>
Date:	09/12/2007 07:31 AM
Subject:	[orbit-dev] Bugfixing 3rd party code due to lack of a release?

---

Hello,

We have a major bug open that can lead to deadlocks
when working with FTP. This is a known problem in
Jakarta Commons Net:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=202758  

We are not able to work around this major issue by
using the original 3rd party lib. But patches exist 
for that very problem in Commons Net, and those patches 
have been applied to the Commons Net codebase:
https://issues.apache.org/jira/browse/NET-3
https://issues.apache.org/jira/browse/NET-73

The patches have been provided and tested by the 
submitter since more than a year. They seem to be
scheduled for an 1.4.x or 1.5 release, but such a
release has not (yet) happened and it is unclear
if it would happen.

I would very much like to apply those patches to the
Commons Net version we use at Eclipse. In fact I did
apply and test the patches, and I'm ready to check in,
but here is what I do not know:

* What do we (in Orbit) think about home-grown bugfix
  versions of 3rd party libs that have not been officially
  released by the maintainer? Can we do this?

* What about IP cleanliness? The patches are 11 and 16 
  lines of code respectively, plain bugfix only, and
  I am in contact with the original author / submitter. 
  Can we let this into Eclipse CVS?

Thanks for any help and insight.

I'd be ready to check in (just 1 .class file and 1
src.zip changed) when I get a GO to put this into the
Fall maintenance.

Thanks,
--
Martin Oberhuber
Wind River Systems, Inc.
Target Management Project Lead, DSDP PMC Member
http://www.eclipse.org/dsdp/tm
_______________________________________________
orbit-dev mailing list
orbit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/orbit-dev