Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [openj9-dev] Code reformatting

Only the C/C++ code under the /runtime directory has been reformatted.  Please review for critical concerns with readability / clarity in the formatted code.
Thanks Rob!
----- Original message -----
From: "Daniel Heidinga" <Daniel_Heidinga@xxxxxxxxxx>
Sent by: openj9-dev-bounces@xxxxxxxxxxx
To: openj9-dev@xxxxxxxxxxx
Subject: [openj9-dev] Code reformatting
Date: Thu, Dec 20, 2018 2:29 PM
There's a discussion at the Eclipse OMR project about reformatting their code base to use a consistent style.  Given the close history between the two projects and overlap in the developer communities, I can see a lot of benefits to having the same coding format between the two projects.
I'd like to get some feedback on whether we should follow suit and reformat OpenJ9 as well.  The area I'm most interested in is whether there are any concrete problems we might encounter with a full reformat.  Please raise any logistics questions on list.
Remember, most of code formatting is personal preference.  Let's only call out areas that are critical concerns with readability / clarity in the formatted code.
Rob has agreed to run the formatter on the OpenJ9 code base as well so we can see how the code looks post-format.  Links to the PR / formatted repo will be shared once available.
Timeline for OpenJ9 would need to be post-0.12.0 with a soft target of mid February assuming there's agreement to go forward here.
----- Original message -----
From: Robert Young <rwy0717@xxxxxxxxx>
Sent by: omr-dev-bounces@xxxxxxxxxxx
To: omr developer discussions <omr-dev@xxxxxxxxxxx>
Subject: Re: [omr-dev] our coding standard
Date: Thu, Dec 20, 2018 1:06 PM
I'd like to reopen the discussion on adopting a common coding standard. Based on the original discussion (which took place over two years ago), we're looking at adopting clang-format based tooling to implement a webkit-style format. I've opened PR #3390 which adds a .clang-format to the root of OMR. The PR has more information and links to code samples. Please take a look!

During (and immediately after) the winter break, there is usually a lull in development. Now might be our best chance to reformat the codebase, and minimize the negative impact on developers. If we can finalize a common clang-format now, then we can start migrating code to the new format early in the new year.

- Rob
omr-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
openj9-dev mailing list
To change your delivery options, retrieve your password, or unsubscribe from this list, visit

Back to the top