Re: [mylyn-integrators] Problems with implementing offline support

[Robert Elves <rob.elves@xxxxxxxxxxx>]

Hi Dennis,

This is a bug since synchronization shouldn't take place when the 
repository is disconnected:

202210: exclude disconnected repositories from user-triggered 
synchronization
https://bugs.eclipse.org/bugs/show_bug.cgi?id=202210

The framework should guard against this condition for you so your 
handler should just work as usual, throwing a CoreException.

-Rob

Dennis Rietmann wrote:
> After digging through the code a bit I think it is the intended 
> behavior that getTaskData is called even though the repository is in 
> offline mode.
> So my next question is: What IS the correct behavior of the connector 
> in such a case? Should it simply throw a CoreException?
>
> regards,
> Dennis
>
> -------- Original Message --------
> Subject:     Problems with implementing offline support
> Date:     Fri, 21 Mar 2008 15:17:59 +0100
> From:     Dennis Rietmann <dennis.rietmann@xxxxxxxxx>
> To:     Mylyn Integrators list <mylyn-integrators@xxxxxxxxxxx>
>
>
>
> Hi everyone,
>
> I have a problem with implementing offline editing in my connector. If 
> I mark the repository as "disconnected" and then open a task from the 
> task list the background synchronization will be launched and 
> getTaskData gets called on my TaskDataHandler (via the  
> RepositorySynchronizationManager->SynchronizeTaskJob.synchronizeTask). 
> getTaskData will try to get the task from the repository which of 
> course fails when working offline.
> I had a look at the Trac connector's TaskDataHandler and it seems to 
> do the same, there is no special check whether the repository is in 
> disconnected mode or not. I think I missed something, because 
> getTaskData shouldn't be called at all by the framework,  but I 
> couldn't figure out what. Does anyone have a suggestion? I already 
> read the section in the Integrators wiki, this seems to be fine.
>
> thanks for any help,
> Dennis
>
>
>
> _______________________________________________
> mylyn-integrators mailing list
> mylyn-integrators@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mylyn-integrators


--
Robert Elves
Mylyn Committer, http://eclipse.org/mylyn