Re: [mylyn-docs-dev] Switch to EPL 2.0 code review

[David Green <david.green@xxxxxxxxxxx>]

Torkild,

Thanks for your cautious approach to merging this change, a license change is a big deal so it's good to take our time and get the visibility/feedback that we want before merging.

You'll be pleased to know that I've merged the change on https://bugs.eclipse.org/bugs/show_bug.cgi?id=533122 (Switch to using EPL 2.0 from EPL 1.0.1)

Unless there's anything left to do, that should complete the switch to EPL 2.0

Lastly, I've cc'd mylyn-docs-dev on this email since all communications regarding eclipse.org development should be open for all to see[1].

Thanks again for your efforts Torkild,

David

1. https://www.eclipse.org/projects/dev_process/development_process_2010.php#2_1_Open_Source_Rules_of_Engagement

On Thu, Apr 19, 2018 at 10:26 AM Torkild U. Resheim <torkildr@xxxxxxxxx> wrote:

Thanks for the review! I bet you had fun doing that ;)

However we don’t need to update the license to fix the problem described in 531943[1]. I’ve already done a fix in 533121[2] and apparently did a poor job searching for the bug report you refer to.

With regards to the license change, I would still like a +1 on this from the project lead since it’s sort of a big deal and we need to put it on record. It should be sufficient to record it in the bug report[3].

Best regards,
Torkild

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=531943
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=533121
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=533122
--
Torkild Ulvøy Resheim
Senior Software Engineer at Itema AS
Granåsveien 3, 7069 Trondheim
+47 922 43 638
torkild.resheim@xxxxxxxx
www.itema.no

> 19. apr. 2018 kl. 19:01 skrev Alexei Trebounskikh <alexei.trebounskikh@xxxxxxxxxxx>:
>
> Thanks!
>
> We work together and he asked me to review it :)
>
> <image.png>
>
>
> Alexei Trebounskikh | Senior Software Engineer | Tasktop
> phone: +1.778.865.5442 (M)
> email: alexei.trebounskikh@xxxxxxxxxxx
> skype: atrebounskikh
>
> On Thu, Apr 19, 2018 at 12:51 AM, Torkild U. Resheim <torkildr@xxxxxxxxx> wrote:
> Sure :) Although I’d like David's +1 first. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=533122
> --
> Torkild Ulvøy Resheim
> Senior Software Engineer at Itema AS
> Granåsveien 3, 7069 Trondheim
> +47 922 43 638
> torkild.resheim@xxxxxxxx
> www.itema.no
>
> > 19. apr. 2018 kl. 02:41 skrev Alexei Trebounskikh <alexei.trebounskikh@xxxxxxxxxxx>:
> >
> > Hello Torkild,
> >
> > Thank you for your contributions! I would love to have your change https://git.eclipse.org/r/#/c/120547/ on master - could you merge it when you have time?
> >
> > I reviewed it, everything looks terrific.
> >
> > Thanks!
> >
> >
> > Alexei Trebounskikh | Senior Software Engineer | Tasktop
> > phone: +1.778.865.5442 (M)
> > email: alexei.trebounskikh@xxxxxxxxxxx
> > skype: atrebounskikh
>
>

--

David Green | VP of Architecture | Tasktop

email: david.green@xxxxxxxxxxx