Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mosquitto-dev] 2.1.0rc1 available for testing

README-compiling does not say what C or C++ version is needed.

With gcc10, which I think defaults to c++11, things built, but when I
brought googletest in scope, I got complaints about not having c++17.
Apparently cmake did not probe for and add --std=c++17; it's missing
from CMakeLists.txt, as is probing for --std=c99.

If I tell pkgsrc to require a c++17 compiler and also to add --std=c++17
to every c++ invocation, then everything builds.

I think what's needed is:

  Decide if mosquitto just requires c++17, or c++17 when testing, and
  someting less (c++11? c++03?) when not testing.  I am not personally
  enthused about requiring c++17 for this kind of infrastructure and I
  am not enthused about using configurations where the tests don't run.

  README-compiling: Say that a c99 compiler and a c++17 compiler are
  needed (or less if not testing and that's the plan).

  CMakeLists: Declare that c99 and c++17 are needed and give the magic
  invocation to cause --std= to be used.  (Or switch based on testing or
  not.)

With that worked around, and python3 patched to the actual version
(build-time binding policy), running tests went better for me than I
ever remember.

Plugins are optional in the build.  I have them off, becuase that used
to make sense, or I thought it did.  Tests try to use plugins and fail.
Ideally, either plugins would not be optional, or tests would check if
configure with plugins or not and skip plugin tests.

Test failures:

            2 - apps-ctrl-broker (Failed)
            3 - apps-ctrl-dynsec (Failed)
           13 - apps-passwd-changes (Failed)
           16 - broker-01-bad-initial-packets (Failed)
           35 - broker-01-plugin-connect-uname-password-denied (Failed)
           55 - broker-02-subpub-qos2-max-inflight-bytes (Failed)
          165 - broker-09-plugin-acl-access-variants (Failed)
          194 - broker-09-plugin-evt-tick (Failed)
          217 - broker-14-dynsec-acl (Failed)
          218 - broker-14-dynsec-allow-wildcard (Failed)
          219 - broker-14-dynsec-anon-group (Failed)
          220 - broker-14-dynsec-auth (Failed)
          221 - broker-14-dynsec-client-invalid (Failed)
          222 - broker-14-dynsec-client (Failed)
          223 - broker-14-dynsec-config-init-env (Failed)
          224 - broker-14-dynsec-config-init-file (Failed)
          225 - broker-14-dynsec-config-init-random (Failed)
          226 - broker-14-dynsec-default-access (Failed)
          227 - broker-14-dynsec-disable-client (Failed)
          228 - broker-14-dynsec-group-invalid (Failed)
          229 - broker-14-dynsec-group (Failed)
          230 - broker-14-dynsec-modify-client (Failed)
          231 - broker-14-dynsec-modify-group (Failed)
          232 - broker-14-dynsec-modify-role (Failed)
          233 - broker-14-dynsec-plugin-invalid (Failed)
          234 - broker-14-dynsec-role-invalid (Failed)
          235 - broker-14-dynsec-role (Failed)
          237 - broker-16-config-huge (Failed)
          238 - broker-16-config-includedir (Failed)
          246 - broker-20-sparkplug-aware (Failed)
          267 - broker-22-http-api-acl (Failed)
          268 - broker-22-http-api-api (Failed)
          269 - broker-22-http-api-auth (Failed)
          270 - broker-22-http-api-file (Failed)
          271 - broker-22-http-api-tls (Failed)
          272 - broker-23-security-acl-file-reload (Failed)
          273 - broker-23-security-password-file-reload (Failed)
          275 - broker-15-persist-bridge-queue-persist_sqlite (Failed)
          276 - broker-15-persist-client-drop-expired-messages-persist_sqlite (Failed)
          277 - broker-15-persist-client-expired-session-persist_sqlite (Failed)
          278 - broker-15-persist-client-msg-in-v3-1-1-persist_sqlite (Failed)
          279 - broker-15-persist-client-msg-in-v5-0-persist_sqlite (Failed)
          280 - broker-15-persist-client-msg-modify-acl-persist_sqlite (Failed)
          281 - broker-15-persist-client-msg-out-clear-v3-1-1-persist_sqlite (Failed)
          282 - broker-15-persist-client-msg-out-dup-v3-1-1-persist_sqlite (Failed)
          283 - broker-15-persist-client-msg-out-queue-v3-1-1-persist_sqlite (Failed)
          284 - broker-15-persist-client-msg-out-v3-1-1-db-persist_sqlite (Failed)
          285 - broker-15-persist-client-msg-out-v3-1-1-persist_sqlite (Failed)
          286 - broker-15-persist-client-msg-out-v5-0-persist_sqlite (Failed)
          287 - broker-15-persist-client-v3-1-1-persist_sqlite (Failed)
          288 - broker-15-persist-client-v5-0-persist_sqlite (Failed)
          289 - broker-15-persist-client-will-persist_sqlite (Failed)
          290 - broker-15-persist-migrate-db-persist_sqlite (Failed)
          291 - broker-15-persist-publish-properties-v5-0-persist_sqlite (Failed)
          292 - broker-15-persist-retain-clear-persist_sqlite (Failed)
          293 - broker-15-persist-retain-v3-1-1-persist_sqlite (Failed)
          294 - broker-15-persist-retain-v5-0-persist_sqlite (Failed)
          295 - broker-15-persist-subscription-v3-1-1-persist_sqlite (Failed)
          296 - broker-15-persist-subscription-v5-0-persist_sqlite (Failed)
          306 - client-02-subscribe-format (Failed)

which of course is vastly fewer than 400!


Back to the top