Re: [mosquitto-dev] Mosquitto 2.0.19 released

[Greg Troxel <gdt@xxxxxxxxxx>]

Peter Korsgaard via mosquitto-dev <mosquitto-dev@xxxxxxxxxxx> writes:

>>>>>> "Roger" == Roger Light via mosquitto-dev <mosquitto-dev@xxxxxxxxxxx> writes:
>
> Hello,
>
>  > Hi Greg,
>  > Could you please check the current `fixes` branch? I've tested the
>  > idea in a virtual NetBSD so hopefully it should be fine.
>
> Those NetBSD changes unfortunately causes a number of build failures on
> Linux. I see you replaced most, but not all pthread_* calls by
> COMPAT_pthread_*?

Interesting that these are blowing up for you.  It does make sense if
there are bare pthread_ not replace with COMPAT that consistency would
be good.  However, a quick grep makes it seem like there is a plan that
isn't "all".

These aren't really "NetBSD changes" though.   The previous code was
trying to turn threading calls on and off in a way that was not
guaranteed to work, and the change is to do it in a cleaner and simpler way.

I don't mean to belittle your report; there's clearly something off, and
of course we should figure it out.

I can reproduce your result, more or less, by adding
-DWITH_THREADING=no.

I suspect that every lib/foo.c that is compiled as part of the broker
needs to have COMPAT_ prefixes.

for i in *.c; do sed -i -e 's/\([      ]\)pthread_/\1COMPAT_pthread_/' $i ; done

with that I can build without threads.