[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [mosquitto-dev] visibility defines
|
Roger Light <roger@xxxxxxxxxx> writes:
> For the most part the non-Linux contributions have come via other
> people when they've had problems. If removing the visibility macro is
> fine for you that seems like the best solution. It seems to be fine on
> FreeBSD as well. (I think it may be time to remove the Symbian
> specific defines)
Sounds good to me.
>> diff --git a/config.h b/config.h
>> index 9f614f8c..b25bea31 100644
>> --- a/config.h
>> +++ b/config.h
>> @@ -7,8 +7,6 @@
>> #ifdef __APPLE__
>> # define __DARWIN_C_SOURCE
>> #elif defined(__FreeBSD__) || defined(__NetBSD__) || defined(__SYMBIAN32__)
>> -# define _XOPEN_SOURCE 700
>> -# define __BSD_VISIBLE 1
>> # define HAVE_NETINET_IN_H
>> #elif defined(__QNX__)
>> # define _XOPEN_SOURCE 600
So you'll commit this, plus also commit gcing SYMBIAN32? If so that
seems like a good plan.
>> I also seen in config.h
>>
>> #ifndef _GNU_SOURCE
>> # define _GNU_SOURCE
>> #endif
>>
>> which is a pretty big hammer.
This still seems like a bug but I can't point to any fallout right now.
