[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [mosquitto-dev] company attribution in pull request
|
I'll amend the commit message. Thanks for the advice Roger.
Hi Matt,
>From my point of view, it would be the least complicated if you added
a note in the commit message. If that's what you do, please amend the
commit then force push and the pull request should update.
Thanks,
Roger
On Fri, 6 Sep 2019 at 19:33, Matt Woelfel <matt@xxxxxxxxxxxxx> wrote:
>
> Hello.
>
> I opened a PR for a bug fix (https://github.com/eclipse/mosquitto/pull/1405). The company I'm contracting for has a guideline for setting the author of a patch to said company. They are pretty pragmatic on addressing this, as they would like to get the fix mainlined over receiving credit. I did do the work on their time, so some sort of attribution seems warranted. Is resetting the author the conventional thing to do, use a keyword in the commit message, some other suggestions?
>
> Thanks,
>
> Matt
> _______________________________________________
> mosquitto-dev mailing list
> mosquitto-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/mosquitto-dev
_______________________________________________
mosquitto-dev mailing list
mosquitto-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/mosquitto-dev
