Re: [mosquitto-dev] patches from pkgsrc for discussion, based on 1.6.1

[Greg Troxel <gdt@xxxxxxxxxx>]

Christoph Willing <chris.willing@xxxxxxxxx> writes:

>> Thanks.  Another question is if it can be proven that the pkgconfig file
>> for a given package will be the same on all architectures.  This is also
>> necessary for a .pc file to be safely installed in
>> ${PREFIX}/share/pkgconfig, even if it's true that this location will be
>> searched.
>
> Well I think it's contents should differ according to the architecture.
> That's partly what it exists for, to point to correct library locations
> (which may be architecture dependent).

In that case it cannot be in share, which by long-standing historical
definition has been files that are architecture independent, and thus
can be mounted from the same place for machines of different
architectures.

Therefore it must be in lib.

> Speaking of which, due to this discussion I was checking the contents of
> the installed libmosquitto.pc and libmosquittopp.pc here and found both
> to be wrong. They both say:
>     libdir=${exec_prefix}/lib
>
> which is OK for many systems but not all, in particular those with lib
> or lib64 directories depending on architecture.

Good point.  I think that's only some GNU/Linux systems, but that's a
significant case :-)

> --- libmosquitto.pc.in.orig     2019-04-27 02:07:59.000000000 +1000
> +++ libmosquitto.pc.in  2019-04-29 17:33:00.802053837 +1000
> @@ -1,7 +1,7 @@
>  prefix=@CMAKE_INSTALL_PREFIX@
>  exec_prefix=${prefix}
>  includedir=${prefix}/include
> -libdir=${exec_prefix}/lib
> +libdir=${exec_prefix}/lib@LIB_SUFFIX@
>
>  Name: mosquitto
>  Description: mosquitto MQTT library (C bindings)
> --- libmosquittopp.pc.in.orig   2019-04-27 02:07:59.000000000 +1000
> +++ libmosquittopp.pc.in        2019-04-29 17:33:23.034679206 +1000
> @@ -1,7 +1,7 @@
>  prefix=@CMAKE_INSTALL_PREFIX@
>  exec_prefix=${prefix}
>  includedir=${prefix}/include
> -libdir=${exec_prefix}/lib
> +libdir=${exec_prefix}/lib@LIB_SUFFIX@
>
>  Name: mosquittopp
>  Description: mosquitto MQTT library (C++ bindings)

As long as this doesn't introduce a bogus lib64 on systems that don't
adopt the "let's rename lib for lib64 fo native and use lib for compat"
approach -- which I think it does not -- looks fine to me.