Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [modisco-dev] I'm willing to fix Bug #397384
Hi Ed,

I've made progress. I used the oomph installer to install the Eclipse 2023-09 committers package and imported the MoDisco project. Lo and Behold! The project was imported with no errors.

I had toolchain issues with the Maven build, which I resolved by setting the configuration in the tycho maven plugin and the tycho surefire plugin.

There's only one build issue: There are test failures in org.eclipse.modisco\org.eclipse.modisco.jee.ejbjar.discoverer.tests that are not caught (the build does not fail):

Launching application org.eclipse.ui.ide.workbench...
!SESSION 2023-12-04 09:24:48.208 -----------------------------------------------
eclipse.buildId=unknown
java.version=17.0.9
java.vendor=Eclipse Adoptium
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en_GB
Framework arguments:  -application org.eclipse.tycho.surefire.osgibooter.uitest -testproperties C:\Tools\committers-2023-09\git\org.eclipse.modisco\org.eclipse.modisco.jee.ejbjar.discoverer.tests\target\surefire.properties -testApplication org.eclipse.ui.ide.workbench -timeout 1800000
Command-line arguments:  -consolelog -data C:\Tools\committers-2023-09\git\org.eclipse.modisco\org.eclipse.modisco.jee.ejbjar.discoverer.tests\target\work\data -application org.eclipse.tycho.surefire.osgibooter.uitest -testproperties C:\Tools\committers-2023-09\git\org.eclipse.modisco\org.eclipse.modisco.jee.ejbjar.discoverer.tests\target\surefire.properties -testApplication org.eclipse.ui.ide.workbench -timeout 1800000

!ENTRY org.eclipse.tycho.surefire.osgibooter 1 0 2023-12-04 09:24:56.789
!MESSAGE starting DumpStackTracesTimer with timeout=1680000 at 2023-12-04 09:24:56 +0000
Running org.eclipse.modisco.jee.ejbjar.discoverer.tests.AllTestsInUIThread
Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 0.053 s <<< FAILURE! - in org.eclipse.modisco.jee.ejbjar.discoverer.tests.AllTestsInUIThread
test001(org.eclipse.modisco.jee.ejbjar.discoverer.tests.TestEjbJar11)  Time elapsed: 0.003 s  <<< FAILURE!
java.lang.AssertionError: Count not find initial@reference:resources/ejb_jar_1_1.xml
        at org.eclipse.modisco.jee.ejbjar.discoverer.tests.TestEjbJar11.initResource(TestEjbJar11.java:51)

test001(org.eclipse.modisco.jee.ejbjar.discoverer.tests.TestEjbJar20)  Time elapsed: 0 s  <<< FAILURE!
java.lang.AssertionError: Count not find initial@reference:resources/ejb_jar_2_0.xml
        at org.eclipse.modisco.jee.ejbjar.discoverer.tests.TestEjbJar20.initResource(TestEjbJar20.java:51)

test001(org.eclipse.modisco.jee.ejbjar.discoverer.tests.TestEjbJar21)  Time elapsed: 0.001 s  <<< FAILURE!
java.lang.AssertionError: Count not find initial@reference:resources/ejb_jar_2_1.xml
        at org.eclipse.modisco.jee.ejbjar.discoverer.tests.TestEjbJar21.initResource(TestEjbJar21.java:51)

test001(org.eclipse.modisco.jee.ejbjar.discoverer.tests.TestEjbJar30)  Time elapsed: 0 s  <<< FAILURE!
java.lang.AssertionError: Count not find initial@reference:resources/ejb_jar_3_0.xml
        at org.eclipse.modisco.jee.ejbjar.discoverer.tests.TestEjbJar30.initResource(TestEjbJar30.java:52)

test001(org.eclipse.modisco.jee.ejbjar.discoverer.tests.TestEjbJar31)  Time elapsed: 0.001 s  <<< FAILURE!
java.lang.AssertionError: Count not find initial@reference:resources/ejb_jar_3_1.xml
        at org.eclipse.modisco.jee.ejbjar.discoverer.tests.TestEjbJar31.initResource(TestEjbJar31.java:52)


Results:

Failures:
  TestEjbJar11.initResource:51 Count not find initial@reference:resources/ejb_jar_1_1.xml
  TestEjbJar20.initResource:51 Count not find initial@reference:resources/ejb_jar_2_0.xml
  TestEjbJar21.initResource:51 Count not find initial@reference:resources/ejb_jar_2_1.xml
  TestEjbJar30.initResource:52 Count not find initial@reference:resources/ejb_jar_3_0.xml
  TestEjbJar31.initResource:52 Count not find initial@reference:resources/ejb_jar_3_1.xml

Tests run: 5, Failures: 5, Errors: 0, Skipped: 0

[ERROR] There are test failures.

Those XML files do exist in the resources folder of the project. I'll investigate later today or tomorrow.

All the best,
Steve Brown

On Wed, 29 Nov 2023 at 09:48, Ed Willink via modisco-dev <modisco-dev@xxxxxxxxxxx> wrote:

Hi

ECA: Thanks.

The MoDisco project page should be the root of all information: https://projects.eclipse.org/projects/modeling.modisco

It lists https://git.eclipse.org/r/modisco/org.eclipse.modisco as the repo to clone.

I'm pretty new to PRs myself and have really only used them as PR to self for SimRel.

MoDisco hasn't yet moved from git.eclipse.org to github/gitlab, so I think you need to use Gerrit for reviews. There is a https://ci.eclipse.org/modisco/job/modisco-master-gerrit/ job but it was last used 3 years ago. So much has changed since then that I'm sure it needs some TLC.

I've never found Gerrit / PRs very useful; I much prefer a good old fashioned patch. (All comments during the review process seem to get lost and links go stale.)

    Regards

        Ed


On 28/11/2023 10:28, Steve Brown via modisco-dev wrote:
Hi,
I've registered for an ECA. How do I get access to the Git repository & how do I submit a pull request?

Many thanks,
Steve Brown

_______________________________________________
modisco-dev mailing list
modisco-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/modisco-dev
_______________________________________________
modisco-dev mailing list
modisco-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/modisco-dev

Back to the top