| Re: [mdt-papyrus.dev] [PROVENANCE INTERNET] Re: [PROVENANCE INTERNET] Fixed ids for UML Element type |
|
Hi, That’s the purpose of this mail. (I personally don’t see any big drawback but I may be missing something) As far as I know, it may be hard to keep ids while editing with a classic EMF editor. But since these files (uml.elementypes and umldi.elementtypes) shouldn’t change a lot, we should be able to avoid issues /Benoît De : mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx]
De la part de GERARD Sebastien It seems to make sense. What are the drawbacks, side effects? Envoyé depuis mon smartphone Samsung Galaxy. -------- Message d'origine -------- De : MAGGI Benoit <Benoit.MAGGI@xxxxxx>
Date : 04/05/2017 08:31 (GMT+01:00)
À : Papyrus Project list <mdt-papyrus.dev@xxxxxxxxxxx>
Objet : [PROVENANCE INTERNET] [mdt-papyrus.dev] Fixed ids for UML Element type
Hi everyone, One of the major change in oxygen is the use of references instead of String to “consume” elementtypes. Basically <specializedTypesID>org.eclipse.papyrus.uml.Abstraction</specializedTypesID> will be replaced by <specializedTypes xsi:type="elementtypesconfigurations:MetamodelTypeConfiguration" href="">org.eclipse.papyrus.uml.service.types/model/uml.elementtypesconfigurations#_ScP1oVYCEeS0WsAAtVmToA"/> in all model ( elementype, palette, new child…) This change was made for good reason but one of the drawback is that we lose
human readability of ids My main concern is the loss of easy Gerrit reviews for use cases such as add an element in palette or new child. I propose to replace uuid (_ScP1oVYCEeS0WsAAtVmToA) by fixed ones (Abstraction) So: <specializedTypes xsi:type="elementtypesconfigurations:MetamodelTypeConfiguration" href="">org.eclipse.papyrus.uml.service.types/model/uml.elementtypesconfigurations#_ScP1oVYCEeS0WsAAtVmToA"/> will become <specializedTypes xsi:type="elementtypesconfigurations:MetamodelTypeConfiguration" href="">org.eclipse.papyrus.uml.service.types/model/uml.elementtypesconfigurations#Abstraction
"/> What are your thoughts on the subject? Regards, Benoît Full example, this <elementTypeConfigurations xsi:type="elementtypesconfigurations:MetamodelTypeConfiguration" xmi:id="_ScP1oVYCEeS0WsAAtVmToA"
identifier="org.eclipse.papyrus.uml.Abstraction" name="UML::Abstraction" hint="UML::Abstraction" editHelperClassName="org.eclipse.papyrus.uml.service.types.helper.DependencyEditHelper"> <iconEntry xmi:id="_ScP1olYCEeS0WsAAtVmToA" iconPath="/icons/full/obj16/Abstraction.gif" bundleId="org.eclipse.uml2.uml.edit"/> <eClass
href="http://www.eclipse.org/uml2/5.0.0/UML#//Abstraction"/> </elementTypeConfigurations> <elementTypeConfigurations xsi:type="elementtypesconfigurations:SpecializationTypeConfiguration" xmi:id="_eu3zwNx0EeWVxMf7SXAfhg"
identifier="org.eclipse.papyrus.umldi.Abstraction_Edge" name="Abstraction Edge" hint="Abstraction_Edge"> <iconEntry xmi:id="_sWEXUNx2EeWVxMf7SXAfhg" iconPath="/icons/full/obj16/Abstraction.gif" bundleId="org.eclipse.uml2.uml.edit"/> <specializedTypes xsi:type="elementtypesconfigurations:MetamodelTypeConfiguration"
href="platform:/plugin/org.eclipse.papyrus.uml.service.types/model/uml.elementtypesconfigurations#_ScP1oVYCEeS0WsAAtVmToA"/> </elementTypeConfigurations> will become: <elementTypeConfigurations xsi:type="elementtypesconfigurations:MetamodelTypeConfiguration" xmi:id="Abstraction" identifier="org.eclipse.papyrus.uml.Abstraction"
name="UML::Abstraction" hint="UML::Abstraction" editHelperClassName="org.eclipse.papyrus.uml.service.types.helper.DependencyEditHelper"> <iconEntry xmi:id="_ScP1olYCEeS0WsAAtVmToA" iconPath="/icons/full/obj16/Abstraction.gif" bundleId="org.eclipse.uml2.uml.edit"/> <eClass
href="http://www.eclipse.org/uml2/5.0.0/UML#//Abstraction"/> </elementTypeConfigurations> <elementTypeConfigurations xsi:type="elementtypesconfigurations:SpecializationTypeConfiguration" xmi:id="Abstraction_Edge"
identifier="org.eclipse.papyrus.umldi.Abstraction_Edge" name="Abstraction Edge" hint="Abstraction_Edge"> <iconEntry xmi:id="_sWEXUNx2EeWVxMf7SXAfhg" iconPath="/icons/full/obj16/Abstraction.gif" bundleId="org.eclipse.uml2.uml.edit"/> <specializedTypes xsi:type="elementtypesconfigurations:MetamodelTypeConfiguration"
href="platform:/plugin/org.eclipse.papyrus.uml.service.types/model/uml.elementtypesconfigurations#Abstraction"/> </elementTypeConfigurations> |