Hi,
Since we are post M5 and I didn’t see any regression when testing the patch, I merged it.
Regards,
Benoit
De : mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx]
De la part de Remi Schnekenburger
Envoyé : jeudi 2 février 2017 16:30
À : Papyrus Project list <mdt-papyrus.dev@xxxxxxxxxxx>
Objet : Re: [mdt-papyrus.dev] Helper Advice getBefore/AfterSetCommand(SetRequest request) not invoked
Hi Benoit,
Thanks for updating the gerrit!
- I do not remember why 2 diagrams were not updated, there were perhaps already relying on the element types or some other gerrit was dedicated to those 2 diagrams.
- The editors other than simple name should be checked with such updates: those who edit something else than the name, like comment tnot a named element), constraints and transitions. Performances should be OK, as this system is already
behaving well in Property view or model explorer.
2017-02-02 16:22 GMT+01:00 MAGGI Benoit <Benoit.MAGGI@xxxxxx>:
Hi Maurice, Rémi,
Thanks for the pointer.
I rebased the patch and regenerate all diagrams.
I looks good to me.
Some questions
-
Class and composite weren’t regenerate in the first patch.
ð
Was it on purpose?
-
Where/What kind of side effect were you expecting?
Regards,
Benoit
De :
mdt-papyrus.dev-bounces@xxxxxxxxxxx [mailto:mdt-papyrus.dev-bounces@xxxxxxxxxxx]
De la part de Remi Schnekenburger
Envoyé : jeudi 2 février 2017 14:25
À : Papyrus Project list <mdt-papyrus.dev@xxxxxxxxxxx>
Objet : Re: [mdt-papyrus.dev] Helper Advice getBefore/AfterSetCommand(SetRequest request) not invoked
Hi Maurice,
That is probably related to the bug 464625: [All Diagrams] Direct edition should rely on service edit to manipulate values
2017-02-02 13:54 GMT+01:00 THEOBALD Maurice (SAFRAN) <maurice.theobald@xxxxxxxxxxxxxxx>:
Hello,
When a block is renamed through the property panel or through the Model explorer, the EditHelperAdvice getAfterSetCommand(SetRequest request) or getAfterSetCommand(SetRequest request)
are invoked.
But if the block is renamed directly in the diagram using the F2 key to enter edit mode, or by a long click, these EditHelperAdvice are not invoked.
That is the right helper to use in that case
Maurice
#
" Ce courriel et les documents qui lui sont joints peuvent contenir des informations confidentielles, être soumis aux règlementations relatives au contrôle des exportations ou ayant un caractère privé. S'ils ne vous sont pas destinés, nous vous signalons qu'il
est strictement interdit de les divulguer, de les reproduire ou d'en utiliser de quelque manière que ce soit le contenu. Toute exportation ou réexportation non autorisée est interdite.Si ce message vous a été transmis par erreur, merci d'en informer l'expéditeur
et de supprimer immédiatement de votre système informatique ce courriel ainsi que tous les documents qui y sont attachés."
******
" This e-mail and any attached documents may contain confidential or proprietary information and may be subject to export control laws and regulations. If you are not the intended recipient, you are notified that any dissemination, copying of this e-mail and
any attachments thereto or use of their contents by any means whatsoever is strictly prohibited. Unauthorized export or re-export is prohibited. If you have received this e-mail in error, please advise the sender immediately and delete this e-mail and all
attached documents from your computer system."
#
_______________________________________________
mdt-papyrus.dev mailing list
mdt-papyrus.dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev
--
Remi Schnekenburger
Senior Software Architect / General Manager
EclipseSource Paris
Email: rschnekenburger@xxxxxxxxxxxxxxxxx
Web: http://eclipsesource.com/paris
Mobil: +49 89 21 555 30 - 25
Phone: +49 89 21 555 30 - 25
Fax: +49 89 21 555 30 - 19
EclipseSource France SAS
7 rue de la Croix Martre
91873 Palaiseau
General Manager: Remi Schnekenburger
_______________________________________________
mdt-papyrus.dev mailing list
mdt-papyrus.dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev
--
Remi Schnekenburger
Senior Software Architect / General Manager
EclipseSource Paris
Email: rschnekenburger@xxxxxxxxxxxxxxxxx
Web: http://eclipsesource.com/paris
Mobil: +49 89 21 555 30 - 25
Phone: +49 89 21 555 30 - 25
Fax: +49 89 21 555 30 - 19
EclipseSource France SAS
7 rue de la Croix Martre
91873 Palaiseau
General Manager: Remi Schnekenburger
|
