Re: [mdt-papyrus.dev] Compilation errors in the Papyrus main-line projec

[Ed Willink <ed@xxxxxxxxxxxxx>]

Hi Christian

During my discussion on cross-project-dev I was recommended not to 
change the BREE arbitrarily to 6 because it would cause so many 
@Override warnings for no real benefit; therefore plugins should stay at 
5 until 6 is needed.

I therefore concluded that a sensible way to change a plugin from 5 to 6 is:

Fix as many warnings as possible on 5. Commit and note those that remain.
Change to 6. Rebuild. Auto-correct all @Override warnings. Should leave 
the same other warnings. Commit.

On no account do any other work while changing, since it is not 
practical to review the typically 250 auto-corrections per plugin.

If the above has been followed maybe it's possible to rework in parallel 
to repeat the above and then diff to establish whether all annotation 
changes were intended.

    Regards

        Ed Willink



On 09/10/2013 23:22, Christian W. Damus wrote:
> Hi, Ed,
>
> Camille has already announced that Papyrus will require 6.0 for Luna, which is fine (and possibly motivated by that cross-project discussion).
>
> The immediate problem is not a pedantic complaint, but actual compilation errors in my workspace that break stuff at run-time.  I don't know how this code compiles for the rest of the team, which is why I am asking for help to understand how to make it work.
>
> I can fix the problems myself by pushing a commit that either
>
>    * removes @Override on interface method implementations or
>    * updates the BREE of all plug-ins
>
> but in the first case somebody's workbench will just continue to add invalid @Overrides automatically and in the second case I don't know that I'm the one that should be doing such a sweeping clean-up action.  Is the rest of the team ready for that?
>
> Thanks,
>
> Christian
>
>
>
> On 2013-10-09, at 6:12 PM, Ed Willink <ed@xxxxxxxxxxxxx> wrote:
>
> > Hi Christian
> >
> > There has been discussion on cross-project-dev.
> >
> > org.eclipse.osgi.util.NLS has moved to Java 6 making any realistic Java 5 usage impossible.
> >
> > The platform actually discontinued Java 5 support in Helios.
> >
> > As a minimum move all launches, or all test plugins to Java 6 and the problem goes away.
> >
> > But pedantically you are right to complain about Java 6 code in a Java 5 BREE plugin.
> >
> >     Regards
> >
> >         Ed Willink
> >
> >
> > On 09/10/2013 22:53, Christian W. Damus wrote:
> > > Hi, Team,
> > >
> > > I've been focusing on some UML2 and CDO work of late but had a need to rebase my Papyrus workspace today on the latest Git master.  I now have a bunch of compilation errors (see below) indicating that code has been committed that requires Java 6.0 source compliance level.  The plan is for 1.0 to require JavaSE-6.0 BREE, but currently all of the bundle manifests still stipulate a J2SE-1.5 BREE.  Consequently, Eclipse PDE compiles these projects with 1.5 source compatibility and generates these errors.
> > >
> > > These errors (in particular the one in the ResourceUpdateService) actually cause stuff to fail in JUnit tests and the run-time workbench.
> > >
> > > Am I the only one with this problem?  If so, why doesn't everybody have it?  I think it would be best if we update the BREEs now, at least in the plug-ins that now actually require 1.6 compatibility for compilation.
> > >
> > > In the mean-time, can anybody suggest how I can work around this?  Note that I also have CDO and other Eclipse projects in this workspace, so overriding the Java compiler settings workspace-wide is not really an option.
> > >
> > > Thanks,
> > >
> > > Christian
> > >
> > > -------- 8<  --------
> > >
> > > The method setStereotypePropertiesInBrace(String) of type LollipopInterfaceFigure must override a superclass method	LollipopInterfaceFigure.java
> > > The method setStereotypePropertiesInCompartment(String) of type LollipopInterfaceFigure must override a superclass method	LollipopInterfaceFigure.java
> > > The method getStereotypesLabel() of type LollipopInterfaceFigure must override a superclass method	LollipopInterfaceFigure.java
> > > The method setStereotypeDisplay(String, Image) of type LollipopInterfaceFigure must override a superclass method	LollipopInterfaceFigure.java
> > > The method run() of type new Runnable(){} must override a superclass method	ResourceUpdateService.java
> > > The method getPrimaryShape() of type NodeEditPart must override a superclass method	NodeEditPart.java
> > >
> > > _______________________________________________
> > > mdt-papyrus.dev mailing list
> > > mdt-papyrus.dev@xxxxxxxxxxx
> > > https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev
> > >
> > >
> > > -----
> > > No virus found in this message.
> > > Checked by AVG - www.avg.com
> > > Version: 2013.0.3408 / Virus Database: 3222/6736 - Release Date: 10/09/13
> > _______________________________________________
> > mdt-papyrus.dev mailing list
> > mdt-papyrus.dev@xxxxxxxxxxx
> > https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev
> _______________________________________________
> mdt-papyrus.dev mailing list
> mdt-papyrus.dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/mdt-papyrus.dev
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2014.0.4142 / Virus Database: 3609/6736 - Release Date: 10/09/13