Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [mdht-dev] Java Version, code style, and source

Just to clarify on the Schematron - it's not ready for a contribution into master, it would need to stay in its own branch. We just contributed an in-development snapshot that's not ready for production use.

On 16/02/16 23:09, Sean Muir wrote:
Morning Dave -
We were hoping  to split the process,  we would commit the updates to the original CDA plugins and then submit separately the schematron generation
Do you think it will be a problem to keep the org.openhealth package names for the runtime cda packages (datatpes,cda) ?  We can change project name, etc 
Who do we need to get involved ?  Ken Rubin can probable speak for hl7 at least initially 

As far as committing to master - just when i get used to branches - sure we can do that,  I will look to delete the develop branch i created

Have we been “reviewing” the changes ?  That part of the process i  am still bit unsure of

thanks

Sean


On Feb 15, 2016, at 7:04 PM, Dave Carlson <dcarlson@xxxxxxxxxxxxxxx> wrote:

Sean,

So, what have you decided on the process for updating eclipse git repo for 'cda' module?  I have not done anything with the 'cda' module in eclipse git, as I thought you intended to submit a new copy of code for IP review??   

OK, I will make changes to 'fhir' module for Java 1.8 and add MDHT format style settings.  I am committing all changes to 'master', which is consistent with process I've seen on all other eclipse.org projects. 

I've been looking into the attach-sources and attach-javadocs.  I did not include these in each plugin pom, as I thought they were already in the module parent pom for 'core' and 'fhir'.  I copied a subset of the module pom content from Papyrus.  I see that they use tycho-source-plugin, which seems to have similar function as maven-source-plugin.

There is also a tycho documentation plugin that may have similar or improved functionality with the maven javadoc plugin?

We can add this to each module pom and should not need to add into each plugin pom.

Dave


On Mon, Feb 15, 2016 at 4:16 PM, Sean Muir <sean.w.muir@xxxxxxxxx> wrote:
Yes we had set 1.8 as a minimum mostly due to the up public updates for 1.7

Just so we do not duplicate updates - i can work on core and cda to get them to use 1.8 and have the same formatter
if you want take care of fhir

Thanks

Sean

On Feb 15, 2016, at 6:12 PM, Dave Carlson <dcarlson@xxxxxxxxxxxxxxx> wrote:

Sean,

For 'core' and 'cda' plugins in Eclipse git, the code format settings and java version are unchanged from when the github freeze copy was taken and submitted to Eclipse IP for review and initial approval.  For FHIR plugins, I used default format settings, but should add the MDHT code formatting.

Have we all agreed that Java 1.8 is now the required minimum version for all MDHT modules?  If so, I will make that setting in the fhir plugin manifests.  The Hudson builds are using Java 1.8.

Dave


On Mon, Feb 15, 2016 at 3:12 PM, sean.muir@xxxxxxxxxxxxxxx <sean.muir@xxxxxxxxxxxxxxx> wrote:
Dave -
        I noticed we are still not consistent with the plugins using the same java version and code formatter
I assume we are java 1.8 and reusing the formatting from MDHT ?

        I also noticed that not all of plugin projects have the java docs and attach source in the pom
Was this intentional ?

Thanks

Sean


_______________________________________________
mdht-dev mailing list
mdht-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdht-dev


_______________________________________________
mdht-dev mailing list
mdht-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdht-dev


_______________________________________________
mdht-dev mailing list
mdht-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdht-dev


_______________________________________________
mdht-dev mailing list
mdht-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/mdht-dev


--

Vadim Peretokin
Clinical Information Modeller
nehta - National E-Health Transition Authority
NEHTA Brisbane Office
Level 31, 400 George St, 4000

Phone: (0) 3023 8573
Email: vadim.peretokin@xxxxxxxxxxxx
Web: www.nehta.gov.au



The information contained in this e-mail message and any accompanying files is or may be privileged or confidential. If you are not the intended recipient, any use, dissemination, reliance, forwarding, printing or copying of this e-mail or any attached files is unauthorised. This e-mail and any attachments may be subject to copyright. Copyright material should not be reproduced, adapted or communicated without the written consent of the copyright owner. If you have received this e-mail in error please advise the sender immediately by return e-mail or telephone and delete all copies. NEHTA does not make any representations or give any guarantees in respect of the accuracy or completeness of any information contained in this e-mail or attached files. Internet communications are not secure, therefore NEHTA does not accept any liability for the contents of this message or attached files.

Back to the top