|
Sounds very reasonable to me too.
If these classes are being used, I wonder if we should maintain them independent of the client code. I suspect there are similar classes in other repos of Lyo.
Jad
Thanks Ricardo, I think this is completely reasonable. Provided no objections come from other Lyo contributors, I can merge your PR. Thank you for your contribution!
On 5 Dec 2018, at 14:29, Ricardo Javier Herrera Ledesma < neormx@xxxxxxxxx> wrote:
Good day lyo devs. I've created a PR for lyo.client project in order to remove final modifier from resource classes like ChangeRequest. Very often in industry, companies have custom properties to add in a ChangeRequest pojo, but this is not possible
as these classes are final. We all know this is not a problema as we have the extendedProperties map; however managing such map and properties is tedious, why just don't remove final modifiers and let programmers add their own custom properties for a better
handling and code looking?
Regards,
Ricardo.
--
I.S.C. Ricardo J. Herrera
SUN Certified JAVA Programmer (SCJP)
Oracle Certified Professional, Java SE 6 Programmer
|
