| Re: [kapua-dev] Build failures |
|
Hi Jens, I did a rebase of my refactored datastore branch (chng-datastoreRestClient) onto develop branch and I need to refactor the work you did for refresh/delete
indexes since datastore will not have ES dependency anymore (except as test scope may be). We can discuss about that in the incoming scrum, if we have time.
However I prefer to tell in advance the 2 options I have.
Option 1:
expose from the client-api (it’s a new module that is not present in develop branch) 2 methods to perform the indexes refresh and delete.
I don’t like too much this solution since someone can accidentally erase the whole datastore invoking the delete indexes method but
- we can prevent this in a similar way I adopted for the KapuaSession (https://github.com/eclipse/kapua/blob/develop/commons/src/main/java/org/eclipse/kapua/commons/security/KapuaSession.java#L94)
- we could expose the refresh method in any case because it might be useful
Option 2:
Keep the ES dependencies as test scope in the datastore and move the refresh/delete code to the datastore module test path. In that way a dependency from ES will be introduced in the datastore module, but as test scoped.
|