Re: [jstl-dev] JSTL TCK Query

[Arjan Tijms <arjan.tijms@xxxxxxxxxxx>]

Hi Kalin,

The source code of the TCK has already been updated (if I'm not mistaken) to accommodate this. It resides at: https://github.com/jakartaee/platform-tck/tree/main/tcks/apis/tags but I like to move it to the Tags project itself (see https://github.com/jakartaee/tags/issues/268)

Besides the change you mention, the code has been refactored (but no functionality other than those quotes has changed AFAIK).

There is a runner available here, which you can use as a base or use as inspiration for the Payara runner: https://github.com/jakartaee/platform-tck/tree/main/glassfish-runner/tags-tck

Let me know if this works for you.

Kind regards,

Arjan Tijms

On Wed, 8 Jan 2025 at 12:28, Kalin Chan via jstl-dev <jstl-dev@xxxxxxxxxxx> wrote:

Hi,

 

In Payara 7.2025.1.Alpha1-SNAPSHOT, running the JSTL 3.0.1 TCK, the following test is failing:

`FAILED........com/sun/ts/tests/jstl/spec/xml/xmlcore/bindings/JSTLClient.java#positiveXPathVariableBindingsTest`

 

From my investigation, the test fails due to the ‘GOLDENFILE’ not expecting a quoted Cookie value, i.e “CookieFound”.

 

As seen below:

ERROR: [TokenizedValidator]: Server's response and goldenfile to not match!

[javatest.batch]

[javatest.batch]             Goldenfile token: CookieFound<br>

[javatest.batch]             Response token:   &#034;CookieFound&#034;<br>

 

It looks like the JSTL TCK does send the quoted Cookie value and this previously passed due to Grizzly removing the quotes, however, this behaviour has now changed ( https://github.com/eclipse-ee4j/grizzly/commit/62b61107461c6d846544f3f8f3f7e3a2e1ecb5e1#diff-22ab214b6074546a2c58a1add254a4c8d830695104799324ffc01eec8233576dR202 CookieHeaderParser.java) – I believe the TCK should be updated to accept the response token.

 

Any thoughts?

 

Thanks,

Kalin Chan
Senior Apprentice Software Engineer

		payara.fish
		+448005385490

Try our fully managed cloud native application runtime. 15 day trial available. Payara.cloud

Payara Services Ltd, Registered office: Malvern Hills Science Park, Geraldine Road, Malvern, WR14 3SZ, United Kingdom
Registered in England and Wales: 09998946 | VAT: GB 193854467

Payara is a proud recipient of the prestigious Queen's Award for Enterprise: International Trade 2021

 

_______________________________________________
jstl-dev mailing list
jstl-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jstl-dev