Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jstl-dev] FYI jakartaee-tck/issues#313 is discussing whether to remove some Web Profile tests...


On Fri, Jul 31, 2020 at 9:14 AM arjan tijms <arjan.tijms@xxxxxxxxx> wrote:
Hi,

Maybe stating the obvious, but did you try to transform the jar using the Transformer?

I agree that should be obvious but I did overlook that option.  I did mention it on https://github.com/eclipse-ee4j/jakartaee-tck/issues/313 as a possible option.
 

Just curious, but have you looked into what they practically speaking really test?


I'm a little puzzled by why https://github.com/eclipse-ee4j/jakartaee-tck/issues/313#issuecomment-667045959 reports that the JSTL (Web Profile) tests are passing in the https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck-grao/job/master/9/testReport/ test run, as no test changes were made (perhaps the test failures are intermittent).

I'm thinking that we should just update the jars in https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/src/web/jstl/compat/onedotzero/WEB-INF/lib and see what happens.  

However, I feedback here, that we should just remove the https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/com/sun/ts/tests/jstl/compat/onedotzero tests, we could do that instead.

Thanks,
Scott


Kind regards,
Arjan



On Thu, Jul 30, 2020 at 8:19 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:
Oops, sent that too soon. :-)

On Thu, Jul 30, 2020 at 2:12 PM Scott Marlow <smarlow@xxxxxxxxxx> wrote:
The issue is that the following test archives are checked into source control:
src/com/sun/ts/tests/jstl/compat/onedotzero/jstl_1_0_compat_web.warsrc/web/jstl/compat/onedotzero/WEB-INF/lib/jstltcktlv_1_0.jar
src/web/jstl/compat/onedotzero/WEB-INF/lib/jstltck_1_0.jar

The above mentioned test archives are checked into [1] and causing test failures when running the Jakarta EE 9 Web Profile JSTL tests for example see [2]

Issue#313 [3] is considering removing the legacy test archives from the Platform TCK (still references Jakarta EE 8 javax.servlet class) or updating them.

I am looking into updating these tests as that might be easier than removing them, however, if you have input on [3], please add to the issue.

Thanks,
Scott


_______________________________________________
jstl-dev mailing list
jstl-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jstl-dev
_______________________________________________
jstl-dev mailing list
jstl-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jstl-dev

Back to the top