Thanks, Arjan. Looks good:
Quick question before you sleep. Is there a way to get PDF and HTML zip file from the build output or do we need to rebuild locally?
Hi,
The API project should not reference the project parent, but the main EE4J parent:
<parent> <groupId>org.eclipse.ee4j</groupId> <artifactId>project</artifactId> <version>1.0.5</version> </parent>
<groupId>jakarta.jms</groupId> <artifactId>jakarta.jms-api</artifactId> <version>2.0.3-SNAPSHOT</version>
All the other projects have something similar.
For correctness it should maybe include an empty relative path though, like was done here:
Kind regards, Arjan
Switching over to jms-dev@
Tried my PR, didn't work :) Doing the BUILD_DIR update now to see if that is better. My main question with that one is the parent pom won't be deployed, so how will people be able to use the api artifact given it references the parent?
Hi,
Still awake, but to retain somewhat of a normal day-night rhythm I'd better go to bed about now ;)
I just approved the changes, if there's anything else let me know. Switching to the API folder is fully supported in the script, as more projects had that requirement (even before we introduced the spec folder and moved the main code to the api/ folder for some projects).
But whatever works ;)
Kind regards, Arjan
Happy to accept any help. I'm on the Jakarta EE development slack if you're still awake.
I made this PR so we can hopefully release from the root directory.
- https://github.com/eclipse-ee4j/jms-api/pull/234
Hi David,
For the JMS job, the workspace path needs to be set to api only, otherwise it'll try to deploy the spec, which of course won't work.
# Directory with project top level pom.xml BUILD_DIR="${WORKSPACE}"
should become:
# Directory with project top level pom.xml BUILD_DIR="${WORKSPACE}/api"
I'd make the change myself otherwise, but maybe you're also working on it right now.
After that you can update the version numbers for the newly staged artefact in 2_messaging-run-tck-against-staged-build
(it has already completed once against the previous 2.02 version)
Kind regards, Arjan
_______________________________________________ jakartaee-spec-project-leads mailing list jakartaee-spec-project-leads@xxxxxxxxxxxTo change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads
_______________________________________________
jakartaee-spec-project-leads mailing list
jakartaee-spec-project-leads@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads
_______________________________________________ jakartaee-spec-project-leads mailing list jakartaee-spec-project-leads@xxxxxxxxxxxTo change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/jakartaee-spec-project-leads
_______________________________________________ jms-dev mailing list jms-dev@xxxxxxxxxxxTo change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jms-dev
|