Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jifa-dev] Custom MAT build - anything else required to build?

The reason why we chose the first way at that time was that we wanted to keep Jifa simple, but now it seems that the second way is more appropriate.
I'm not familiar with Eclipse RCP, looking forward to your sample, we could file an issue to track this problem on https://github.com/eclipse/jifa

Thanks
Denghui

------------------------------------------------------------------
From:Jason Koch <jkoch@xxxxxxxxxxx>
Send Time:2020年8月27日(星期四) 08:53
To:董登辉(卓昂) <denghui.ddh@xxxxxxxxxxxxxxx>; jifa developer discussions <jifa-dev@xxxxxxxxxxx>
Subject:Re: [jifa-dev] Custom MAT build - anything else required to build?

Hi Denghui

It seems like most of the changes are to allow use of the MAT code without hosting inside the Eclipse Platform framework.

I think there are two choices:
- Maintain an embedded / forked version of the code. This would require maintenance of patches but gives most control.
- Create JIFA as an Eclipse RCP application so that it operates as a CLI application and hosts the vertx code. This would get you the Platform framework and allow direct use of Eclipse plugins. It means writing an implementation of IApplication and implementing start() but I think this should be ok.

Have you explored Eclipse plugin? I could try to create a sample.

Thanks
Jason

On Wed, Aug 26, 2020 at 5:58 AM Denghui Dong <denghui.ddh@xxxxxxxxxxxxxxx> wrote:
Hi Jason,
The attachment is the modification(relative to 84436df7 Merge "324967: Hide queries which are not relevant") made by us.
To be honest, the modification is not friendly, we need a more elegant way to build such a jar, what do you think?

Thanks,
Denghui
------------------------------------------------------------------
From:董登辉(卓昂) <denghui.ddh@xxxxxxxxxxxxxxx>
Send Time:2020年8月26日(星期三) 16:26
To:jifa-dev <jifa-dev@xxxxxxxxxxx>
Subject:Re: [jifa-dev] Custom MAT build - anything else required to build?

Yes, we made some changes except heap layout support in MAT so that we can use Mat Parser API directly.

I will share the modification later.

However, I am now rethinking whether those changes are necessary and whether there is a way for us to use their API without modifying the source code of MAT. If we have to make changes, we should file an issue to the mat community

Denghui
------------------------------------------------------------------
From:Jason Koch <jkoch@xxxxxxxxxxx>
Send Time:2020年8月26日(星期三) 03:03
To:jifa-dev <jifa-dev@xxxxxxxxxxx>
Subject:[jifa-dev] Custom MAT build - anything else required to build?

I would like to build Eclipse MAT from source and I have only noticed the getHeapLayout.

Are there any other changes you have included in MAT that I would need to be aware of or do you have specific build instructions?

Thanks
Jason
_______________________________________________
jifa-dev mailing list
jifa-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jifa-dev


Back to the top