Re: [jgit-dev] File handle leaks in JGit 7.2.0 Pack.java

[Luca Milanesio <luca.milanesio@xxxxxxxxx>]

Hi Mark,

Thanks for sharing the findings; JGIt 7.2 is also included in the forthcoming Gerrit v3.12 release (we are at RC1 at the moment), therefore I’m also echoing your post to the repo-discuss mailing list.

I’ll start investigating them and come back to both mailing lists.

Have you created a JGit issue already? (see [1]).

Luca.

[1] https://github.com/eclipse-jgit/jgit/issues

On 8 Apr 2025, at 04:10, Mark Waite via jgit-dev <jgit-dev@xxxxxxxxxxx> wrote:

I've been evaluating JGit 7.2.0 for inclusion in a Jenkins git client

plugin release.

I've found a file handle leak in Pack.java.  There were

significant changes in Pack.java between 7.1.0 and 7.2.0 as part

of 51d6c63fe1602a by Martin Fick.

I suspect that the open/close accounting is not always handled

correctly.  I've not yet been able to create a repeatable failure

case in a JGit test but I've documented a repeatable failure case

with Jenkins in https://github.com/MarkEWaite/JGit-7.2.0

I'm posting here in hopes that someone that is more familiar with

the JGit internals could look at the stack traces and suggest

places that I should investigate more fully.

The stack traces are:

https://github.com/MarkEWaite/JGit-7.2.0/blob/master/leak.02

https://github.com/MarkEWaite/JGit-7.2.0/blob/master/leak.01

https://github.com/MarkEWaite/JGit-7.2.0/blob/master/leak.05

I'll continue investigating in any case and will share results

as they develop.

Mark Waite

_______________________________________________
jgit-dev mailing list
jgit-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jgit-dev