Re: [jgit-dev] auto-formatting source code ?

[Mark Waite <mark.earl.waite@xxxxxxxxx>]

On Tue, May 14, 2024 at 6:32 AM Matthias Sohn via jgit-dev <jgit-dev@xxxxxxxxxxx> wrote:

I am tired of discussing source code formatting and some JGit contributors don't use Eclipse IDE hence they have a hard time getting formatting right since we currently use the Eclipse auto-formatter.

Hence I propose we adopt the approach the Gerrit project is using and switch from Eclipse auto-formatter to google-java-format [1] and add a Gerrit submit rule and a label "CodeStyle" which the CI can vote on to block changes which weren't properly auto-formatted using google-java-format.

WDYT ?

We've had very good results with automated code formatting in the Jenkins project.  We use the Apache Maven `spotless`  plugin with `palantirJavaFormat` (derived from google code format).

The reasoning for the change to automated formatting and the details of that change are included in https://github.com/jenkinsci/plugin-pom/pull/733

Mark Waite