Re: [jgit-dev] Advice for some old changes

[Nasser Grainawi <nasser@xxxxxxxxxxxxxx>]

On Nov 30, 2020, at 12:35 PM, Matthias Sohn <matthias.sohn@xxxxxxxxx> wrote:

On Mon, Nov 30, 2020 at 4:59 PM Nasser Grainawi <nasser@xxxxxxxxxxxxxx> wrote:

On Nov 17, 2020, at 2:32 PM, Nasser Grainawi <nasser@xxxxxxxxxxxxxx> wrote:

Hey folks,

I’m looking to see if I can get some help moving a few out of date changes forward.

Change series 1: 122288: Restore preserved packs during missing object seeks. | https://git.eclipse.org/r/c/jgit/jgit/+/122288

This series is adding a feature to JGit that would allow for safer object pruning during repacking by providing a way to restore a “missing” object from a backup of the most recent pack files. I don’t think there were any objections to it, but reviews just stalled out.

Change series 2: 24295: RFC: BucketQueue (LinearMinFinder) | https://git.eclipse.org/r/c/jgit/jgit/+/24295

This series modifies the DateRevQueue implementation to use a more performant data structure. We think it also fixes a bug in DateRevQueue (the parent change), but that bug has become deeply ingrained in the latest JGit tip tests, so it’s quite a challenge (for me) to fix all the occurrences. There weren’t any concerns raised or real review comments added on the change.

I’m willing to rebase these, but I’m wondering if there’s additional modifications needed to help them get reviewed/merged. Would someone be able to provide some feedback/direction for me?

Anyone have thoughts they could share to help me move forward?

Sorry for the late response, I am pretty swamped since a while.

I am interested and have these 2 changes on my list of changes which I should review since a pretty long time :-)

Please rebase them. I will try to find time to review them.

Will do, thanks Matthias!