[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [jgit-dev] public Repository class, internal FileRepository class, and Name/Identity
- From: Shawn Pearce <spearce@xxxxxxxxxxx>
- Date: Sat, 6 Apr 2013 10:54:09 -0700
- Delivered-to: email@example.com
On Mon, Apr 1, 2013 at 10:49 AM, <james.moger@xxxxxxxxxxx> wrote:
> When the JGit servlet's pack factories are created, the
> HttpServletRequest is provided as a parameter to the pack creation
> methods and the requested repository name (id) can be re-extracted from
> the servlet request url. This is how Gitblit currently works-around the
> missing repository name information.
I think both Gerrit and our server at Google get the name and store it
in a request attribute on the HttpServletRequest. Although I'll admit
that in our server at Google we extend DfsRepository and also tend to
rely on the getRepositoryDescription().getRepositoryName(). However
like getDirectory() the input URL name doesn't necessarily always
match to the internal name used by the DFS storage.
> Unfortunately for the Git Daemon there is no url to parse in the
> DaemonClient object.
Add it to this? The DaemonClient object acts like the
HttpServletRequest. It carries the remote peer IP address, but is just
missing the command, repository URL and parsed virtual host name. I
think it is reasonable to add these to the type.