[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] Invalid Path Problem

On 11/24/2012 12:39 AM, Robin Rosenberg wrote:
> 
> 
> ----- Ursprungligt meddelande -----
>> oh:
>>
>> if (isWindows) {
>> 			// Space or period at end of file name is ignored by Windows.
>> 			// Treat this as a bad path for now. We may want to handle
>> 			// this as case insensitivity in the future.
>>
>> ... but this is only true in explorer, but not filesystem wise, is
>> it?
> 
> It is the file system that ignores spaces and periods at the end of
> file.
> 
> The check was introduced as part of checking for really really
> bad names and the comments suggest we could handle it differently, but
> no voices was raised against this. The important change was with regard
> to security issues, but I added checks for names that the file system
> could not reproduce too. E.g. if you create the file "a." in windows,
> it will create the file "a", without the dot.

ok, accepted. but then in a heterogeneous environment (windows/linux) the checks should be the same on all platforms, otherwise you can commit things that the others cannot checkout. :/

Markus

> 
> -- robin
>