Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] PreReceive hook ReceiveCommand rejection messages

On Fri, Mar 30, 2012 at 09:37, <james.moger@xxxxxxxxxxx> wrote:
Hi JGit Team,

PreReceive rejection.

receiveCommand.setResult(Result.REJECTED_OTHER_REASON, "this git server
does not like you")

I expected that the reason would be displayed client-side.  This does
not appear to be the case.  The JavaDoc for sendError suggests that
setResult(result, reason) is the appropriate technique for reporting a
rejection error message to the client.

Yes, that's correct.
Is Gitblit doing something
incorrect here?  Should the Gitblit receive hook call sendError manually
if a prereceive command result is one of the REJECTED enum values?

You may choose to call sendError independently, but those error messages are displayed before the per-branch error messages.

Until recently there was a bug where the C git client would fail to display per-ref status messages under some circumstances. What git client version are you using? The bug I'm thinking of was fixed in 5238cbf65638d7a097bdb5ca8226f5acbe31f143, included in v1.7.9.2.

reference thread:
jgit-dev mailing list

Back to the top