[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [jgit-dev] stack overflow in branch deletion
|
Nevertheless I wonder why calling getRef inside a RefsChanged Event causes
RefsChange events over and over again.
I think we had a similar issue at another location of Egit.
--Jens
On 21.03.12 09:52, "Markus Duft" <markus.duft@xxxxxxxxxx> wrote:
>On 03/21/2012 09:41 AM, Baumgart, Jens wrote:
>> I am wondering how the call stack looks like:
>>
>> at org.eclipse.jgit.lib.Repository.getRef(Repository.java:765)
>> at
>>
>>org.eclipse.egit.core.internal.indexdiff.IndexDiffCacheEntry$2.onRefsChan
>>ge
>> d(IndexDiffCacheEntry.java:88)
>>
>>
>> IndexDiffCacheEntry.onRefsChanged does not call getRef. And it should
>>not
>> do, event processing is done asynchronously using a Job.
>
>uh... my own change If43a04410492ee6976f00d18d99c7b0a935c0689 introduces
>the problem...
>
>>
>>
>> --Jens
>>
>>
>>
>> On 21.03.12 08:48, "Markus Duft" <markus.duft@xxxxxxxxxx> wrote:
>>
>>> at org.eclipse.jgit.lib.Repository.getRef(Repository.java:765)
>>> at
>>>
>>>org.eclipse.egit.core.internal.indexdiff.IndexDiffCacheEntry$2.onRefsCha
>>>ng
>>> ed(IndexDiffCacheEntry.java:88)
>>