[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jgit-dev] Committing generated code?

On Thu, May 5, 2011 at 14:57, Ferry Huberts <mailings@xxxxxxxxx> wrote:
> On 05/05/2011 09:45 PM, Shawn Pearce wrote:
>> I would like feedback about http://egit.eclipse.org/r/3345
>>
>> I am proposing to replace the hand-coded usage of TinyProtobuf in the
>> DHT code with the Google Protocol Buffers Java implementation. Its
>> faster and more widely supported.
>
> we placed the generated code under a "generated" package, like
>  org.eclipse.jgit.generated.proto.buffers
>
> that kept it clear that it was generated :-)

OK. That's what I'll do then. I had already planned to put them into
their own plugin + Java package, but I didn't think to put the word
"generated" in the name. :-)

> we also placed the actual source from which the generated code is built
> in the source tree (for obvious reasons)

Of course. Otherwise its impossible to make changes.

-- 
Shawn.