Re: [jgit-dev] [egit-dev] HistogramDiff now live on egit.eclipse.org

[Matthias Sohn <matthias.sohn@xxxxxxxxxxxxxx>]

2010/10/14 Shawn Pearce <spearce@xxxxxxxxxxx>

On Wed, Oct 13, 2010 at 3:29 PM, Shawn Pearce <spearce@xxxxxxxxxxx> wrote:
> On Wed, Oct 13, 2010 at 10:04 AM, Shawn Pearce <spearce@xxxxxxxxxxx> wrote:
>> On Wed, Oct 13, 2010 at 9:10 AM, Chris Aniszczyk <caniszczyk@xxxxxxxxx> wrote:
>>> On Tue, Oct 12, 2010 at 7:21 PM, Shawn Pearce <spearce@xxxxxxxxxxx> wrote:
>>>> I just upgraded Gerrit to use HistogramDiff for the line-level
>>>> differences.  Its still using MyersDiff for the intraline differences,
>>>> because those are character based and HistogramDiff can't get good low
>>>> occurrence matches on those.
>>>
>>> Hrmmm... not sure if this is related but hitting an issue looking at a diff...
>>>
>>> 1) http://egit.eclipse.org/r/#change,1739
>>> 2) click 'Side-by-Side' for org.eclipse.jgit/pom.xml
>>> 3) Application Error everytime :(

The fix for this is now deployed.  Please keep an eye out for other
failures, since we are dogfooding the new algorithm.  :-)

looks like here

http://egit.eclipse.org/r/#patch,unified,1766,3,org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/history/GitHistoryPage.java

the new algorithm shows too coarse grained diffs. Large blocks seem to be changed

but these blocks only differ in a few lines, so that it's hard to spot what really changed.

-- 
Matthias