Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[jgit-dev] Re: iplog for JGit

Wayne Beaton <wayne@xxxxxxxxxxx> wrote:
>> * Please add an optional version attribute to project.
> Done.

Thanks.  Right now its only the commit SHA-1, but the code knows
how to dump the tag version number if its being asked to produce
an IP log for a tagged revision.

>> * What is the type attribute of bug for?
> Type is 'A' for attachment, or 'C' for comment. Ultimately, I'm not sure  
> if this is valuable. It's certainly Bugzilla-specific.

Thanks.  I changed the generator to hardcode this to "A".

>> * How do I assign contributor ids?
> The contributor Id is the login name in Bugzilla.

Isn't this their verified email address?

> I assume you have  
> something along these lines.

Well, we have their verified email address, but slightly more
difficult to get is their unique username they created in the
Gerrit database, or their unique account ID number assigned to
their account...

> I included this value primarily so that the  
> IP Log Tool could do comparisons with the server. You need to have  
> something that uniquely identifies the contributor so you can match up  
> the record to compare. For your immediate purposes, this value isn't  
> strictly required.

I guess this is also an issue then with committer id, right?

And committer affiliation, I'm producing bogus data for that right
now by chopping the email address.  :-)

>> * Is it OK for bug size to be number of lines added?
> Lines or bytes. Whichever is easier for you.

Lines makes a lot more sense, doesn't it?

I'm only reporting the lines inserted (or replaced) by the author,
not the lines they deleted.  And certainly not reporting the
context size.  One thing I don't like about the current IP log PHP
tool is its counting bytes for attachments, which makes it hard to
judge just how much of an impact "31.2 KB" really is.


Back to the top