Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jetty-users] org.eclipse.jetty.http.HttpField

I disagree. The quotes are part of the value and are significant.

What about this:

If-Match: W/"ab35ef1bc78", W/"5be73a9c523"`

On Thu, Oct 29, 2020 at 10:04 AM Joakim Erdfelt <joakim@xxxxxxxxxxx> wrote:
That header ...

`If-Match: "ab35ef1bc78", "5be73a9c523"`


as a Field with a List of 2 values.
Value 1: ab35ef1bc78
Value 2: 5be73a9c523

ETag is not special here, the only listed special case handling for field-value in the spec is `Set-Cookie`.

- Joakim
Joakim Erdfelt / joakim@xxxxxxxxxxx


On Thu, Oct 29, 2020 at 9:47 AM Nils Kilden-Pedersen <nilskp@xxxxxxxxx> wrote:
Yes, that's my point. ETags require quotes, but they're being removed.

On Thu, Oct 29, 2020 at 9:25 AM Tamás Cservenák <tamas@xxxxxxxxxxxxx> wrote:
To me it seems does requite DQUOTE around it...

Thanks
T

On Thu, Oct 29, 2020 at 3:07 PM Nils Kilden-Pedersen <nilskp@xxxxxxxxx> wrote:

After debugging for a weird problem the entire day yesterday, I finally figured out why my ETag value was losing its quotes. For some reason, the innocently sounding HttpField.getValues apparently (needlessly?) appears to assume that comma separated header values might be quoted (not sure why, I don’t think it’s spec), and thus removes required quotes from etags, causing parsing failure later.

So, e.g. this header:

If-Match: "ab35ef1bc78", "5be73a9c523"

will return invalid ETag values (unquoted).

I would consider this a bug, but not sure why quote removal is even there, as I don’t see the HTTP spec requiring quotes around comma separated values.

_______________________________________________
jetty-users mailing list
jetty-users@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jetty-users
_______________________________________________
jetty-users mailing list
jetty-users@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jetty-users
_______________________________________________
jetty-users mailing list
jetty-users@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jetty-users
_______________________________________________
jetty-users mailing list
jetty-users@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jetty-users

Back to the top