[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [jetty-users] Sessions are not invalidated at shutdown any longer
|
- From: Dirk Olmes <dirk.olmes@xxxxxxxxxx>
- Date: Thu, 28 May 2020 12:35:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=exentra.de; dmarc=pass action=none header.from=exentra.de; dkim=pass header.d=exentra.de; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MOLeESRXe9rnOkW0fSspP+OatSBQcsAzToJNcTk0T68=; b=H9HR/fE53/Yv0XQcQyOitXV2TSVc5UdDHxsfCDvW32Fhgth4wSqEmaN1IlzngytY/lBMBKb9fH6025JxFipxUJxO7m6+oE1Y9Emizl/96Ztzdk5a7sWdkz2Ua8AngtkjObwZZEXmlU6+JbB7kDRCiI9DZg0Zdkv1IWHQEyPJ01KiN7XmBRHonko/QwF+pmL3dEYHpvyjxm1DtixN4wJhEEC8g+p/clO3FxDYzpc2nZs6rkEDt3FK4isdKYOyti8XYCDcrvj4UhG2vb/JNFPI8V8P5XTHFqpgdmx4RbactMOJj68rnI5/KTkeGhugP/WacvXWFo9U1OPhyn+gxFLtAQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5rTuriBSPdkZwxNpM778SdM1ZCzPGiHzpyAKPafz0JfO9LZVpcU4dDfPrvchHuScWjKsdnVWQWheadnS4DjKM7NncYzZYnfSElR2avheWywvPDLTft5EhjoQ23VleZB2gu84mmHTA7Mrz7MAfX/KlOzEoy9gnmlJAz2itYu5xy6IbvJ3AoWOum7oAIDI2UD+ZtPJuRb1JFVWIUrsuaHFM6igrbHvOJMiLMJ7eGDIoMNYt0H1/cNEmPU4ExPvTxc2xeow3PtgKFkJi+142z4R5GO2pIIoWOKjFE5I/QaAkB9tCIylLXIFIpwsbnx7kM6L1PnoMOgURfG+/UQa8PW7g==
- Autocrypt: addr=dirk.olmes@xxxxxxxxxx; keydata= mQINBFSGuAkBEADMQGhpRSMydLmvN1SabK02Wj5jx9jyKg8cKVkn3SxDE33ZLdjYfVPx6E1K FC3CMB+GFxTQhcu1zEXYjNliv/SucYAPomnEb4f/YzJYcH3wTDNcv37D2lWWVetoHeu22zue uFaD4TI2IFBj+20ZNml+Lx7mhQvGUKO7Zv2A87aMPnLke/iUWSYfTJaUwP6ZfTyJ/V8BnkXv j4Q+VzkmEEUBk9ugCdLlJtXnCz26fz3zwhgmdTIszmskxU6Uo5RGVIoXBykNGd5j1xJnAMJR epE/5iP6xwtJjpO6lnKhTlVfatO7Hsyq6krmEmhyy3s7/HMAFaCPTA9ABbo/kP15qTEiLraz DlpaiGu4M8PRzC+0yQvPEVxer4KQyTn+7r0whUHDasu82x6BeCbFCjz2NVttTlSMY+AY3d67 r8Ezu/xr2bgQByPnVgVXDDg5i2EB/fe4qK0Cj5Am4CI7GvMpqbgjwfE4wL+CnkwPdm1/jRjG NEGzfghxKfpjS7e/x+irG9RCQ6HP9bPqoJJ3SMkx+GJaU1dQwNR7e7+edxbeTv9JFl6OjqB3 4ZYrr4zZYxzYZM+v0QtuzZ+0KFJi4ukFV8BA90EgGaAm53EaPtXXUu7MQ5Kr8jxTMgnUccMv WtDo07SfA13k+CvyaFBMne7Q6QgBBA1IrQInjPNTGyWfampQJwARAQABtCJEaXJrIE9sbWVz IDxkaXJrLm9sbWVzQGV4ZW50cmEuZGU+iQI8BBMBAgAmAhsjBwsJCAcDAgEGFQgCCQoLBBYC AwECHgECF4AFAlSGuv8CGQEACgkQwZ9f8ypd2SnxEQ/8CfcMh21w0AHkV+7bXaFFpQ7SlRSs 8FW5zCwxNRugiLZ2gp+MNebze+4GJxJzrOiVLHjbIta+BlkWghXbfmnufxSN2McdOGJjTUj3 XOqrkBCZ6ukgYfj9LydB2fj/aS+MPU8Xg2k7d0aQlivkaSodV7csFCFsIw+EvFKwqqx+Wc4o KgzRwxFAPL+NME3gHUsoM1Hk6bNGoW1RQLJdm21PE3qUbxL2Usyli43Hi8PQZ5QXuGnIYGX5 JOhGpajMb0tZrkA7mJn04y2ZTOGlA7imUTBxfG8NT5Du/KhHPoqiLbc3ApNBGrIKVrq0h8Nt bS7lcXY+sq1JOtsv1fNVjfKuJ/5Ec9y4+YC9+qKI7lvv/DmZSAJlJ7Dqr6a9/87sRgbtJniY KdQnlbfB4J5zz+rXq/CjFTLUFzfGmNiNpaJGcSNZRoql5Slp1Go4BbvHqbSrFRo0HL0jnRIE JNXAhowttIyxMe6JdeeEqcAyoZFo0wADtwTxTSZZh+6/2N5CyFE02fAw170UclxH25mEJXXd ft6GSQ26n2RCMdD/oDlHWXKFjzV86X952Vsu6EGxnpMSf0ggOhYh71+nBgyP3Ww/nozi5Lme 3MNI3iCdm5dtfn9Sy+nyLoJ7ei1FZ8np5Dccpoe/a3/aQNVORDtbbNFnoOuOz7ZPeizRJrqV pbNSvzG5Ag0EVIa4CQEQAL3/yVKsqL+ppm0A+tgxRX745HLyBpn//wJ7Oac8+KIo/8/8JNLu iVXXXFKela9S/CRrC7jl9G9jy1SHl5hTag5pa/6RuF+dXzO0ofWyfAhincn+HT0A7iu/YGxz yp8SRZsEOmTVOcl9e94IMkoyB6+6U3ZOhI70V+DObX5gJMJWYZJsuMBDX6Fb0oSp6zluExXv mfB7Im+HtwGHuEhhojCatemgNED5hggMllFPW9KApaB43asOSPx+ewHZwTGR+wNjrGF7rsur KwIoQ/t1qjaW6DWYbfasFSm2D5landYke1nKqKauhmgDYOt+CtlYWJY5rFxH6PHVbdNXpCWv cM//xLqt/Q3h9SwIjzPplHM6OaphKec8UQ6HytbbT2QwDrzG2iL0Rpqz77rbVC7uwsw60xbd g07IkI8C90dkaiZ2g7rofCKk/Hvz4u31CJHaVsVkNpNfhkVYkTLpxdvHqBscLng27Bf5KDfo KD2os1rhWzWUkHgZqrTjPhkKA65Mag8Jfaik1lcJCHxkuMX/iLXpIRCeWzLFfCTO4dkKcVSu Tjt9a1HAFGp/Pky2m0Yv3YD3+UEEKGkk2jbG9NF9RD8u9XJFjc4N3LCK5jFGf9garHn09t6p ZXOOTJk5Y5PCDKYVFDUrCeRsbXtQW5F1Vi0UVKEYstpxd6pE2b8TBm6BABEBAAGJAh8EGAEC AAkFAlSGuAkCGwwACgkQwZ9f8ypd2SkFsRAAkjf+MFpOkHgeUpaPzjyScJwiChrjtc87AO/r DYGDk+yeY5gV2LHbDFGbec5MV2ytJu9pyhhfgMG5wNwQoxYDiPqTq4ssygR6N69nhOZvB/T/ 5yXbHOGsjAGHEy5bjruGlHeOJ62Xn4EcUBGH5JtvVFoCcOItGGBnJjSJhANHg2a1fkPL9jkH YYzajhpZJYiYHfzhbNGQfy6b/TiruCaTQn74rbnfUFmrHAlvEIzFt+mLspouLHfM4zV5XwDI C7HUhal9EYn4aAxdJkwM2+/UhuQ/AgEIYJN4QqqbLKp1BXC7chpJtdH9YfnRfgl0qqYh6igM 9aAjXOr2NiKskiu5dsAScqwT3J6meNr2n3FVAMjOQgxPaDagJ/CXxhtcwKGJOeE825tUJG4C VYmUUOtwcKxvrBLav0JhxMeCaE2fQi0wy1o1F0Taj91ctn/OH+KO6JuD31OQNC8kWcuWCS0D 1i6IKPd8+PjTb97FDXDfoIHTlmtwtam/x4x8sYyAE7/7NrRH8iEGykeFdk7qRdq7zkXF9id2 0gEb2Hz3eWZduNoNNqRvEL13H3ln4seRcBKOmuunjUElwu0GOEHgzcPJ/2vL5cJEhHlzQxeH 9rj5DNwytV3zoxwQilg7juQHFYjr9f5YmlECSiJn+i4BVndp1W/illfglDTcabpe1fTowGU=
- Delivered-to: jetty-users@xxxxxxxxxxx
- List-archive: <https://www.eclipse.org/mailman/private/jetty-users>
- List-help: <mailto:jetty-users-request@eclipse.org?subject=help>
- List-subscribe: <https://www.eclipse.org/mailman/listinfo/jetty-users>, <mailto:jetty-users-request@eclipse.org?subject=subscribe>
- List-unsubscribe: <https://www.eclipse.org/mailman/options/jetty-users>, <mailto:jetty-users-request@eclipse.org?subject=unsubscribe>
- Organization: exentra GmbH
On 5/28/20 11:08 AM, Jan Bartel wrote:
> Sounds like you need the NullSessionDataStore:
> https://github.com/eclipse/jetty.project/blob/jetty-9.4.x/jetty-server/src/main/java/org/eclipse/jetty/server/session/NullSessionDataStore.java
... whis is active by default, yes.
But then in DefaultSessionCache's shutdown method the _sessionDataStore
is not null and the else branch will not be executed, i.e. the sessions
will not be invalidated as they are "stored" by the NullSessionDataStore.
IMHO the code is inconsistent here: some parts of AbstractSessionCache
assume that there is a _sessionDataStore (e.g. doStop(), commit(Session)
etc.) and some parts are safely guarded with null checks.
DefaultSessionCache suggests that it's OK to have no _sessionDataStore ...
I imagine I could hack together a subclass of DefaultSessionCache, grab
the sessions and invalidate them manually but I think a proper fix in
the Jetty codebase would be better.
-dirk
