[jetty-users] ProxyConnectionFactory Custom TLVs

[Josh Spiegel <joshlakewg@xxxxxxxxx>]

Hi,

In version 2 of the proxy protocol, it allows for application-specific TLV types:

https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt

See section 2.2.7.  Basically the type code in range  0xE0..0xEF gets associated with an arbitrary block of bytes.  

Currently it appears these custom TLVs are being ignored:

https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-server/src/main/java/org/eclipse/jetty/server/ProxyConnectionFactory.java#L545

I think ideally these custom TLVs should be accessible by the underlying connection.  For example, proxyEndPoint could simply maintain a map from type -> byte[].  e.g. 

  default:

      proxyEndPoint.setCustom(type, value);

Or perhaps it could even reuse setAttribute() for this if it treats the type code as a string. 

Does this make sense?  Is there any appetite for this change?

Thanks,

Josh