Re: [jetty-users] After upgrading to 9.4.14.v20181114 getContentAsString

[Simone Bordet <sbordet@xxxxxxxxxxx>]

Hi,

On Sun, Dec 2, 2018 at 4:19 PM Alexander Farber
<alexander.farber@xxxxxxxxx> wrote:
>
> Good afternoon,
>
> I run a custom WebSocketServlet for Jetty, which sends short text push notifications (for an async mobile and desktop word game) to many platforms (Facebook, Vk.com, Mail.ru, Ok.ru also Firebase and Amazon messaging) using a Jetty HttpClient instance:
>
> public class MyServlet extends WebSocketServlet {
>     private final SslContextFactory mSslFactory = new SslContextFactory();
>     private final HttpClient mHttpClient = new HttpClient(mSslFactory);
>
>     @Override
>     public void init() throws ServletException {
>         super.init();
>
>         try {
>             mHttpClient.start();
>         } catch (Exception ex) {
>             throw new ServletException(ex);
>         }
>
>         mFcm      = new Fcm(mHttpClient);    // Firebase
>         mAdm      = new Adm(mHttpClient);    // Amazon
>         mApns     = new Apns(mHttpClient);   // Apple
>         mFacebook = new Facebook(mHttpClient);
>         mMailru   = new Mailru(mHttpClient);
>         mOk       = new Ok(mHttpClient);
>         mVk       = new Vk(mHttpClient);
>     }
>
> This has worked very good for the past year (thank you!), but since I have recently upgraded my WAR-file to use Jetty 9.4.14.v20181114 the trouble has begun -
>
> public class Facebook {
>     private final static String APP_ID      = "XXXXX";
>     private final static String APP_SECRET  = "XXXXX";
>     private final static String MESSAGE_URL = "https://graph.facebook.com/%s/notifications?"; +
>             // the app access token is: "app id | app secret"
>             "access_token=%s%%7C%s" +
>             "&template=%s";
>
>     private final HttpClient mHttpClient;
>
>     public Facebook(HttpClient httpClient) {
>         mHttpClient = httpClient;
>     }
>
>     private final BufferingResponseListener mMessageListener = new BufferingResponseListener() {
>         @Override
>         public void onComplete(Result result) {
>             if (!result.isSucceeded()) {
>                 LOG.warn("facebook failure: {}", result.getFailure());
>                 return;
>             }
>
>             try {
>                 // THE jsonStr SUDDENLY CONTAINS PREVIOUS CONTENT!
>                 String jsonStr = getContentAsString(StandardCharsets.UTF_8);
>                 LOG.info("facebook success: {}", jsonStr);
>             } catch (Exception ex) {
>                 LOG.warn("facebook exception: ", ex);
>             }
>         }
>     };
>
>     public void postMessage(int uid, String sid, String body) {
>         String url = String.format(MESSAGE_URL, sid, APP_ID, APP_SECRET, UrlEncoded.encodeString(body));
>         mHttpClient.POST(url).send(mMessageListener);

You cannot reuse BufferingResponseListener, it was never intended to
work in this way.
It was just a coincidence that it was working before.
Allocate the BufferingResponseListener for each request/response.

-- 
Simone Bordet
----
http://cometd.org
http://webtide.com
Developer advice, training, services and support
from the Jetty & CometD experts.