Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jetty-users] Case sensitivity issues with upper-case scheme in HttpClient#send

Hi,

On Tue, May 26, 2015 at 5:22 PM, Bradley Wagner
<bradley.wagner@xxxxxxxxxxxxxx> wrote:
>
> Can’t tell if this is a bug or just a minor inconsistency. I searched a bit in the bugs and didn’t see any mention of it. We’re on jetty-all-9.2.4.v20141103.
>
> Basic problem is an IllegalArgumentException on a link that’s using a non-normalized scheme: e.g. “HTTPS”.
>
> Problem appears to be that the request’s scheme is being lower-cased and validated as being either “http” or “https” here:
>
> https://github.com/eclipse/jetty.project/blob/jetty-9.2.4.v20141103/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java#L513-L518
>
> The lower-cased scheme is being used to construct the Destination and underlying Origin: https://github.com/eclipse/jetty.project/blob/jetty-9.2.4.v20141103/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java#L517
>
> but then we’re doing a case-senstitive comparison of the original request’s scheme to the now normalized scheme from the Destination’s Origin which results in an IllegalArgumentException:
>
> https://github.com/eclipse/jetty.project/blob/jetty-9.2.4.v20141103/jetty-client/src/main/java/org/eclipse/jetty/client/HttpDestination.java#L158-L159
>
> Should i just file?

Yes please: https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Jetty

-- 
Simone Bordet
----
http://cometd.org
http://webtide.com
http://intalio.com
Developer advice, training, services and support
from the Jetty & CometD experts.
Intalio, the modern way to build business applications.


Back to the top