Re: [jetty-users] JDBCSessionManager dirty operations

[Jan Bartel <janb@xxxxxxxxxxx>]

Cemo,

This will need some refactoring of the implementation of the session
interface, but I'm not opposed to looking into it.

Can you open a bug for this please and assign to me?

thanks
Jan

On 27 February 2014 06:25, Cemo <cemalettin.koc@xxxxxxxxx> wrote:
> Hi,
>
> Current org.eclipse.jetty.server.session.JDBCSessionManager has
> removeAttribute as this:
>
>   public void removeAttribute (String name)
>
>  {
>       super.removeAttribute(name);
>
>
>
>      _dirty=true;
>  }
>
>
> This has a side effect because of making dirty for every removing operation.
> This is causing a lot of trouble because each jstl set ( c:set ) call in JSP
> pages is also calling removeAttribute internally. What I am suggesting is
> that something like this:
>
>
>    @Override
>    public void removeAttribute(String name) {
>
>
>
>       synchronized (this){
>          Object attribute = getAttribute(name);
>
>
>
>          if(attribute != null){
>
>
>
>             super.removeAttribute(name);
>
>
>
>             _dirty = true;
>          }
>       }
>    }
>
> public
>
>
> https://gist.github.com/cemo/9236abe34d2b126242ad
>
> What do you think?
>
> _______________________________________________
> jetty-users mailing list
> jetty-users@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/jetty-users
>



-- 
Jan Bartel <janb@xxxxxxxxxxx>
www.webtide.com
'Expert Jetty/CometD developer,production,operations advice'