Re: [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing

From: Jan Bartel <janb@xxxxxxxxxxx>
Date: Wed, 5 Dec 2018 13:38:29 +0100
Delivered-to: jetty-dev@xxxxxxxxxxx
List-archive: <https://www.eclipse.org/mailman/private/jetty-dev>
List-help: <mailto:jetty-dev-request@eclipse.org?subject=help>
List-subscribe: <https://www.eclipse.org/mailman/listinfo/jetty-dev>, <mailto:jetty-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://www.eclipse.org/mailman/options/jetty-dev>, <mailto:jetty-dev-request@eclipse.org?subject=unsubscribe>

Hi Raymond,

Doing some testing with the updated version of spifly and we're experiencing a problem with one of our tests in jetty-10.0.x. We need to use an osgi fragment to extend the manifest for the javax.websocket-api bundle to allow it to use the ServiceLoader to find implmentations of the javax.websocket.ContainerProvider interface. In the past this has worked well, however it has stopped working in jetty-10.0.x and I was wondering if maybe there are any changes in spi-fly that could account for that? The test in question is here: https://github.com/eclipse/jetty.project/blob/jetty-10.0.x-3162_jetty_servlet_api/jetty-osgi/test-jetty-osgi/src/test/java/org/eclipse/jetty/osgi/test/TestJettyOSGiBootWithJavaxWebSocket.java

Jan

On Sat, 24 Nov 2018 at 23:13, Raymond Auge <raymond.auge@xxxxxxxxxxx> wrote:

Thanks Jan,

I've rebased and pushed my PR here: https://github.com/eclipse/jetty.project/pull/3142

Sincerely,
- Ray

On Sat, Nov 24, 2018 at 3:17 PM Jan Bartel <janb@xxxxxxxxxxx> wrote:
Raymond,

If you're building with jdk8, then that might cause the issue with osgi - I missed fixing it for jdk8. Just checked in a change that should make it work, so do a pull and you should be ok.

Jan

On Fri, 23 Nov 2018 at 21:18, Jan Bartel <janb@xxxxxxxxxxx> wrote:
Hi Raymond,

Good news!

I just checked in a change to 9.4.x that fixed a problem with the version of the conscrypt jar. If you've done a pull in the last hour then you should have that change. The version of the conscrypt jar is provided as a system property defined on the surefire plugin. Make sure you do a build from the top level first, skipping all tests before you do the OSGi tests.
Jan

On Fri., 23 Nov. 2018, 19:59 Raymond Auge <raymond.auge@xxxxxxxxxxx wrote:
Hey all,

So spifly 1.2 released and I wanted to send this PR with the change, but the tests failed with:

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.085 s <<< FAILURE! - in org.eclipse.jetty.osgi.test.TestJettyOSGiBootHTTP2Conscrypt
[ERROR] org.eclipse.jetty.osgi.test.TestJettyOSGiBootHTTP2Conscrypt Time elapsed: 0.001 s <<< ERROR!
org.ops4j.pax.exam.TestContainerException: org.osgi.framework.BundleException: Error occurred installing a bundle.
Caused by: org.osgi.framework.BundleException: Error occurred installing a bundle.
Caused by: java.lang.IllegalArgumentException: invalid version "null": non-numeric "null"
Caused by: java.lang.NumberFormatException: For input string: "null"

It seems unrelated to the change, but I wanted to ask about it.
Is this known?

Sincerely,
- Ray

On Fri, Nov 16, 2018 at 2:16 AM Olivier Lamy <olamy@xxxxxxxxxxx> wrote:
Hi Ray
Feel free to make a pull request this will be build in Jenkins. (if not ready yet add WIP label in the description)

On Fri, Nov 16, 2018 at 5:38 AM Raymond Auge <raymond.auge@xxxxxxxxxxx> wrote:
Ok, after making a further change I was able to use this patch:

diff --git a/jetty-osgi/test-jetty-osgi/pom.xml b/jetty-osgi/test-jetty-osgi/pom.xml
index 16cc573faf..1acc7c0481 100644
--- a/jetty-osgi/test-jetty-osgi/pom.xml
+++ b/jetty-osgi/test-jetty-osgi/pom.xml
@@ -155,18 +155,8 @@
              <groupId>org.apache.felix</groupId>
              <artifactId>org.apache.felix.framework</artifactId>
          </exclusion>
-         <exclusion>
-             <groupId>org.ow2.asm</groupId>
-             <artifactId>asm-util</artifactId>
-         </exclusion>
      </exclusions>
     </dependency>
-    <dependency>
-     <groupId>org.apache.aries</groupId>
-      <artifactId>org.apache.aries.util</artifactId>
-      <version>1.1.1</version>
-     <scope>test</scope>
-    </dependency>
     <dependency>
      <groupId>com.sun.activation</groupId>
       <artifactId>javax.activation</artifactId>
diff --git a/jetty-osgi/test-jetty-osgi/src/test/java/org/eclipse/jetty/osgi/test/TestOSGiUtil.java b/jetty-osgi/test-jetty-osgi/src/test/java/org/eclipse/jetty/osgi/test/TestOSGiUtil.java
index e30a2e8195..c1f324ee8b 100644
--- a/jetty-osgi/test-jetty-osgi/src/test/java/org/eclipse/jetty/osgi/test/TestOSGiUtil.java
+++ b/jetty-osgi/test-jetty-osgi/src/test/java/org/eclipse/jetty/osgi/test/TestOSGiUtil.java
@@ -110,7 +110,6 @@ public class TestOSGiUtil
         res.add(mavenBundle().groupId( "org.ow2.asm" ).artifactId( "asm" ).versionAsInProject().start());
         res.add(mavenBundle().groupId( "org.ow2.asm" ).artifactId( "asm-commons" ).versionAsInProject().start());
         res.add(mavenBundle().groupId( "org.ow2.asm" ).artifactId( "asm-tree" ).versionAsInProject().start());
-        res.add(mavenBundle().groupId( "org.apache.aries" ).artifactId( "org.apache.aries.util" ).versionAsInProject().start());
         res.add(mavenBundle().groupId( "org.apache.aries.spifly" ).artifactId( "org.apache.aries.spifly.dynamic.bundle" ).versionAsInProject().start());
         res.add(mavenBundle().groupId( "org.eclipse.jetty.toolchain" ).artifactId( "jetty-osgi-servlet-api" ).versionAsInProject().noStart());
         res.add(mavenBundle().groupId( "javax.annotation" ).artifactId( "javax.annotation-api" ).versionAsInProject().start());
(END)

and have all the OSGi tests pass.

Now regarding the felix framework issue, the scope is runtime and so I guess pax-exam is being overly pedantic about such dependencies. The goal of adding that runtime dependency was merely to perform a resolver check to make sure the package imports are correct. I'll try to figure something out.

Sincerely,
- Ray

On Thu, Nov 15, 2018 at 4:59 AM Jan Bartel <janb@xxxxxxxxxxx> wrote:
Hi Raymond,

I tested with spifly 1.2-SNAPSHOT and it seems to work fine.
Note, however, that I still needed to exclude felix and asm from the dependency in order for the pax-exam test framework to be happy:

<dependency>
<groupId>org.apache.aries.spifly</groupId>
<artifactId>org.apache.aries.spifly.dynamic.bundle</artifactId>
<version>1.2-SNAPSHOT</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.apache.felix</groupId>
<artifactId>org.apache.felix.framework</artifactId>
</exclusion>
<exclusion>
<groupId>org.ow2.asm</groupId>
<artifactId>asm-util</artifactId>
</exclusion>
</exclusions>
</dependency>

If you need me to test something specific, let me know.

cheers
Jan

On Wed, 14 Nov 2018 at 18:56, Raymond Auge <raymond.auge@xxxxxxxxxxx> wrote:
Hello everyone,

Recently we've had some updates to Apache Aries SpiFly around ASM 7 and Java 11 and I know Jetty has had struggles with it.

I have a new 1.2-SNAPSHOT [1] I would like to test against jetty before releasing. However I cannot successfully run the build on either Java 8 or Java 11 (at HEAD of jetty-9.4.x) no matter what I try (it always fails in websocket client tests).

]$ mvn -version
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T14:33:14-04:00)
Maven home: /home/rotty/bin/maven/apache-maven-latest
Java version: 11.0.1, vendor: Azul Systems, Inc., runtime: /usr/lib/jvm/zulu-11-amd64
Default locale: en_CA, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-39-generic", arch: "amd64", family: "unix"

I'm wondering if someone could maybe run the tests to check this version (need to add Apache Snapshots repo:
                <repository>
                        <id>apache-snapshots</id>
                        <url>https://repository.apache.org/content/groups/snapshots/</url>
                        <layout>default</layout>
                </repository>
)
OR
assist me in resolving the build issues?

Sincerely,
- Ray

[1] https://repository.apache.org/content/repositories/snapshots/org/apache/aries/spifly/org.apache.aries.spifly.dynamic.bundle/1.2-SNAPSHOT/org.apache.aries.spifly.dynamic.bundle-1.2-20181114.042106-8.jar

--
Raymond Augé (@rotty3000)
Senior Software Architect Liferay, Inc. (@Liferay)
Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance)
_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev

--
Jan Bartel <janb@xxxxxxxxxxx>
www.webtide.com
Expert assistance from the creators of Jetty and CometD

_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev

--
Raymond Augé (@rotty3000)
Senior Software Architect Liferay, Inc. (@Liferay)
Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance)
_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev

--
Olivier
_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev

--
Raymond Augé (@rotty3000)
Senior Software Architect Liferay, Inc. (@Liferay)
Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance)
_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev

--
Jan Bartel <janb@xxxxxxxxxxx>
www.webtide.com
Expert assistance from the creators of Jetty and CometD

_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev

--
Raymond Augé (@rotty3000)
Senior Software Architect Liferay, Inc. (@Liferay)
Board Member & EEG Co-Chair, OSGi Alliance (@OSGiAlliance)
_______________________________________________
jetty-dev mailing list
jetty-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jetty-dev

Jan Bartel <janb@xxxxxxxxxxx>

www.webtide.com
Expert assistance from the creators of Jetty and CometD

References:
- [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing
  - From: Raymond Auge
- Re: [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing
  - From: Jan Bartel
- Re: [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing
  - From: Raymond Auge
- Re: [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing
  - From: Olivier Lamy
- Re: [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing
  - From: Raymond Auge
- Re: [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing
  - From: Jan Bartel
- Re: [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing
  - From: Jan Bartel
- Re: [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing
  - From: Raymond Auge

Prev by Date: Re: [jetty-dev] HTTPS to HTTP cookie issue(cookie config issue when switching between https and http)
Next by Date: Re: [jetty-dev] HTTPS to HTTP cookie issue(cookie config issue when switching between https and http)
Previous by thread: Re: [jetty-dev] Aries SpiFly 1.2-SNAPSHOT testing
Next by thread: [jetty-dev] Jetty 9.4.14 Released - Corrections for Servlet Listeners bug & Java 8 and ALPN Users
Index(es):
- Date
- Thread

Breadcrumbs