Re: [jetty-dev] Github and Jetty

[Eirik Bjørsnøs <eirbjo@xxxxxxxxx>]

Jesse,

What to do if I have more information / observations on an existing,
resolved Bugzilla?

Should I comment on the Bugzilla, or open a new Github issue,
referring to the closed Bugzilla?

The issue is https://bugs.eclipse.org/bugs/show_bug.cgi?id=482728

Observations:
------------------

It seems to me that Maven's plexus realm classloader only exposes,
org.slf4j.*, org.slf4j.spi.*, but that org.slf4.helpers.*  is not
exposed. (Additionally, Maven somewhat magically excludes our plugin's
dependency on slf4j-api.)

This causes a CNFE on any attempt to load classes from
org.slf4j.helpers.* from inside a Maven plugin.

In our case, the hudson slf4j spy jar is what triggers this. It causes
a different Slf4J logger impl to be used instead of Maven's
slf4j-simple.

Jetty's Log.java detects this Slf4J logger to be an instance of
LocationAwareLogger and wraps it in a JettyAwareLogger, which again
uses MessageFormat from org.slf4j.helpers

We worked around this issue by setting the this system property in the
Hudson job:
-Dorg.eclipse.jetty.util.log.class=org.eclipse.jetty.util.log.StdErrLog

Question / feedback:
---------------------------

Since Maven hides org.slf4.helpers, JettyAwareLogger cannot currently
be used inside Maven. This isn't really a Hudson problem. Hudson
exposes a problem of running Jetty inside Hudson.

Could the Jetty project rewrite JettyAwareLogger to _not_ use
FormattingTuple and MessageFormatter?

Maven could also stop hiding parts of slf4j-api, but they probably
hide it for some reason?


Cheers,
Eirik.

On Wed, Feb 17, 2016 at 12:36 AM, Jesse McConnell
<jesse.mcconnell@xxxxxxxxx> wrote:
>
> Just a heads up that the Jetty codebase is now hosted completely at GitHub.
>
> http://github.com/eclipse/jetty.project
>
> Also, Bugzilla is a thing of the past and the open issues should be migrated
> out to GitHub Issues over the next day or three when we'll be hopefully
> getting it set into read-only mode.
>
> Apologies if you were watching the repository and got a slew of mail as the
> issues were migrated over!
>
> Bright note is that it is much easier for us to accept contributions through
> github, you just need to have a CLA on file and sign the pull request
> appropriately!
>
> cheers,
> Jesse
>
> --
> jesse mcconnell
> jesse.mcconnell@xxxxxxxxx
>
> _______________________________________________
> jetty-dev mailing list
> jetty-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/jetty-dev