Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jersey-dev] How to contribute

Thanks, I suspected the involvment of 3rd party stuff for the modules missing in the sourcecode. Any pointers in how to solve the unit tests? Because these were broken before the project came to Eclipse. Or should we stay tuned for this as well?

On Wed, May 2, 2018 at 3:20 PM Christian Kaltepoth <christian@xxxxxxxxxxxx> wrote:
Hi Jan,

thanks a lot for explaining the situation. Do you think it would make sense to remove the examples from the pom for now? Or do you expect some more feedback from the 3rd party in the near future?

Thanks a lot

Christian

Am Mi., 2. Mai 2018 um 15:07 Uhr schrieb Jan Supol <jan.supol@xxxxxxxxxx>:
Hello,

There are few examples missing from the contribution. The examples
depend on 3rd party code, and we need to get the 3rd party approved to
be used in Jersey. The plan is to contribute the missing examples as
soon as they got approved. The poms were not adjusted to the missing
examples in a hope of returning the examples to repository soon.

I am sorry for the inconvenience, we are working on it. This is probably
the state of inconsistency that happens with any technology being
contributed; the first stage of contribution accepts only the original
code, the 3rd party dependencies are being approved "on the fly".

Please stay tuned.

Thanks,

Jan


On 02.05.2018 14:56, Kenneth Westelinck wrote:
> I see :( So, how do we proceed here?
>
> On Wed, May 2, 2018 at 2:52 PM Christian Kaltepoth
> <christian@xxxxxxxxxxxx <mailto:christian@xxxxxxxxxxxx>> wrote:
>
>     I always got test failures even in earlier versions. And AFAIK we
>     are not alone with this issue. I think this is definitely
>     something to improve.
>
>     Am Mi., 2. Mai 2018 um 14:39 Uhr schrieb Kenneth Westelinck
>     <kenneth.westelinck@xxxxxxxxx <mailto:kenneth.westelinck@xxxxxxxxx>>:
>
>         Indeed. I removed these modules from the examples pom. But now
>         I am stuck in this test.
>         BTW, this test was already failing in the original Jersey repo
>         ... makes me wonder how they ever managed to release 2.27 :/
>
>         On Wed, May 2, 2018 at 1:53 PM Christian Kaltepoth
>         <christian@xxxxxxxxxxxx <mailto:christian@xxxxxxxxxxxx>> wrote:
>
>             Hi Kenneth,
>
>             I'm also having problems running the build. A "mvn clean
>             install" on a fresh checkout gives:
>
>             $ mvn clean install
>             [INFO] Scanning for projects...
>             [ERROR] [ERROR] Some problems were encountered while
>             processing the POMs:
>             [ERROR] Child module
>             /home/ck/projects/jersey/jersey/examples/bean-validation-webapp
>             of /home/ck/projects/jersey/jersey/examples/pom.xml does
>             not exist @
>             [ERROR] Child module
>             /home/ck/projects/jersey/jersey/examples/feed-combiner-java8-webapp
>             of /home/ck/projects/jersey/jersey/examples/pom.xml does
>             not exist @
>             [ERROR] Child module
>             /home/ck/projects/jersey/jersey/examples/flight-mgmt-webapp
>             of /home/ck/projects/jersey/jersey/examples/pom.xml does
>             not exist @
>             [ERROR] Child module
>             /home/ck/projects/jersey/jersey/examples/monitoring-webapp
>             of /home/ck/projects/jersey/jersey/examples/pom.xml does
>             not exist @
>             [ERROR] Child module
>             /home/ck/projects/jersey/jersey/examples/oauth2-client-google-webapp
>             of /home/ck/projects/jersey/jersey/examples/pom.xml does
>             not exist @
>             [ERROR] Child module
>             /home/ck/projects/jersey/jersey/examples/shortener-webapp
>             of /home/ck/projects/jersey/jersey/examples/pom.xml does
>             not exist @
>             [ERROR] Child module
>             /home/ck/projects/jersey/jersey/examples/sparklines of
>             /home/ck/projects/jersey/jersey/examples/pom.xml does not
>             exist @
>             [ERROR] Child module
>             /home/ck/projects/jersey/jersey/examples/tone-generator of
>             /home/ck/projects/jersey/jersey/examples/pom.xml does not
>             exist @
>
>             Looks like there are some examples missing in the initial
>             contribution!?!
>
>             Christian
>
>
>             Am Mi., 2. Mai 2018 um 12:42 Uhr schrieb Kenneth
>             Westelinck <kenneth.westelinck@xxxxxxxxx
>             <mailto:kenneth.westelinck@xxxxxxxxx>>:
>
>                 Hi all,
>
>                 Kudos to you guys for moving to eclipse. I guess this
>                 is a big step forward.
>
>                 I still had an outstanding pull request when jersey
>                 was still under the Oracle umbrella, so I want to
>                 recreate this PR on the jersey project you can find on
>                 github.
>                 So I did a complete checkout and now I am trying to
>                 build it.
>                 My first failing test is JerseyInvocationTest. This is
>                 on a clean checkout.
>
>                 Any pointers how to get started on the codebase?
>
>                 Thanks!
>
>
>                 regards,
>
>                 Kenneth Westelinck
>
>                 _______________________________________________
>                 jersey-dev mailing list
>                 jersey-dev@xxxxxxxxxxx <mailto:jersey-dev@xxxxxxxxxxx>
>                 To change your delivery options, retrieve your
>                 password, or unsubscribe from this list, visit
>                 https://dev.eclipse.org/mailman/listinfo/jersey-dev
>
>
>
>             --
>             Christian Kaltepoth
>             Blog: http://blog.kaltepoth.de/
>             Twitter: http://twitter.com/chkal
>             GitHub: https://github.com/chkal
>
>             _______________________________________________
>             jersey-dev mailing list
>             jersey-dev@xxxxxxxxxxx <mailto:jersey-dev@xxxxxxxxxxx>
>             To change your delivery options, retrieve your password,
>             or unsubscribe from this list, visit
>             https://dev.eclipse.org/mailman/listinfo/jersey-dev
>
>         _______________________________________________
>         jersey-dev mailing list
>         jersey-dev@xxxxxxxxxxx <mailto:jersey-dev@xxxxxxxxxxx>
>         To change your delivery options, retrieve your password, or
>         unsubscribe from this list, visit
>         https://dev.eclipse.org/mailman/listinfo/jersey-dev
>
>
>
>     --
>     Christian Kaltepoth
>     Blog: http://blog.kaltepoth.de/
>     Twitter: http://twitter.com/chkal
>     GitHub: https://github.com/chkal
>
>     _______________________________________________
>     jersey-dev mailing list
>     jersey-dev@xxxxxxxxxxx <mailto:jersey-dev@xxxxxxxxxxx>
>     To change your delivery options, retrieve your password, or
>     unsubscribe from this list, visit
>     https://dev.eclipse.org/mailman/listinfo/jersey-dev
>
>
>
> _______________________________________________
> jersey-dev mailing list
> jersey-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/jersey-dev

_______________________________________________
jersey-dev mailing list
jersey-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jersey-dev


--
_______________________________________________
jersey-dev mailing list
jersey-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jersey-dev

Back to the top