Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-ui-dev] New contribution: couple of questions
Thanks for the feedback, Dani.

Interesting that the PMC members are interested in expanding the idea to use visual notifications; I had that idea in my head (I was thinking of whatever mechanism the Error Reporter is using), but as a follow-on feature. I wanted to address a narrow, specific need before jumping into something more complex. Baby steps, and all that.

I see the success/failure audio as a viable stand-alone feature, distinct from OS-level or Mylyn-style notifications; the two can be offered together or separately, they don't have to be coupled. Audio feedback is useful when the user isn't paying attention to the window/screen.

I'd hope that committers would at least take a look at the implementation and try it out before deciding that a broader, more complex solution is better. Especially since I know how limited JDT is on people and time. I'll work on getting a pull request submitted so you can have a look.

Eric
June 14, 2016 2:12 PM
Hi Eric

The PMC is about to send a note regarding the Update releases soon, but let's answer your question here directly: For the Eclipse top-level project the main goal for Update releases is still to increase stability. Therefore, like for API changes (including additions), any feature work needs to be brought forward to the PMC for approval. Only fixes and features that are already working fine in master for some time can be brought forward. Having the work first in master and tested by the community before it gets backported, is our normal workflow. Also, any backport needs a review from another committer. I hope that also answers question 2.

Using sounds is something that we rarely used so far - at the moment I can only remember the beep when Find/Replace wraps. Please have a look at the discussion we had today in the PMC call.

We don't have a dedicated person that creates our icons and for sounds we didn't even have the need so far. If you don't create the icon yourself, then a CQ will be needed.

Dani



From:        Eric Rizzo <eclipse-mail@xxxxxxxxxxxx>
To:        jdt-ui-dev@xxxxxxxxxxx
Date:        13.06.2016 15:43
Subject:        [jdt-ui-dev] New contribution: couple of questions
Sent by:        jdt-ui-dev-bounces@xxxxxxxxxxx



I've created https://bugs.eclipse.org/bugs/show_bug.cgi?id=496003and am
preparing a pull request to implement it. I'm going through the
contribution information on the wiki, but I have a couple of questions:

1) I realize the Neon release is right around the corner and my work, if
accepted, won't be in it. However, is it reasonable to expect it to be
eligible for Neon SR1? It's all new functionality but not API, so I'm
unsure. Obviously I'd like to see it included in SR1 if possible, but I
just don't know the policy or requirements.

2) Which branch should I be basing my work on? I've done it so far based
on master, but if the answer to #1 above is "yes" I assume I should be
based on another, as it appears master is for Oxygen release.

3) My work involves both sounds and icons:
    a) For icons, is there someone who typically does icon work for JDT
(or Platform)? I'm no good at design or pixel-pushing, so for the time
being I've grabbed some icons from a free (Creative Commons Attribution
licensed) set, but I don't know if that's allowable or who I can turn to
for help if its not.
   b) For sounds, again I've included some CC licensed sounds for now,
but don't know if there is any precedent for sound files anywhere in
Platform or other Eclipse "core" projects.

That's it for now; I appreciate any guidance while I get up to speed on
JDT contributions.

Eric

_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev



_______________________________________________
jdt-ui-dev mailing list
jdt-ui-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
June 13, 2016 3:43 PM
I've created https://bugs.eclipse.org/bugs/show_bug.cgi?id=496003 and am preparing a pull request to implement it. I'm going through the contribution information on the wiki, but I have a couple of questions:

1) I realize the Neon release is right around the corner and my work, if accepted, won't be in it. However, is it reasonable to expect it to be eligible for Neon SR1? It's all new functionality but not API, so I'm unsure. Obviously I'd like to see it included in SR1 if possible, but I just don't know the policy or requirements.

2) Which branch should I be basing my work on? I've done it so far based on master, but if the answer to #1 above is "yes" I assume I should be based on another, as it appears master is for Oxygen release.

3) My work involves both sounds and icons:
    a) For icons, is there someone who typically does icon work for JDT (or Platform)? I'm no good at design or pixel-pushing, so for the time being I've grabbed some icons from a free (Creative Commons Attribution licensed) set, but I don't know if that's allowable or who I can turn to for help if its not.
   b) For sounds, again I've included some CC licensed sounds for now, but don't know if there is any precedent for sound files anywhere in Platform or other Eclipse "core" projects.

That's it for now; I appreciate any guidance while I get up to speed on JDT contributions.

Eric


Back to the top