Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jdt-ui-dev] First contribution help 
https://git.eclipse.org/r/#/c/70055/ looks technical OK to me, now a
JDT UI committer could review the change...

On Wed, Apr 6, 2016 at 9:56 PM, Markus Oley <markus.oley@xxxxxxxxxxxxxx> wrote:
> Ah OK, so I only have to wait for the Change to be reviewed?
> Thanks for your help
>
>> Am 06.04.2016 um 21:50 schrieb Lars Vogel <lars.vogel@xxxxxxxxxxx>:
>>
>> That is fine, only means that you current master has moved on but that
>> happens every time a commit is done.
>>
>> You can use the "Rebase" button in the UI to rebase on master, if
>> there is no merge conflict.
>>
>> On Wed, Apr 6, 2016 at 9:48 PM, Markus Oley <markus.oley@xxxxxxxxxxxxxx> wrote:
>>> Hi again,
>>>
>>> I have provided Change 70055 - hudson started build #692, but gerrit says: Cannot merge, do I have to do anything to solve this problem?
>>>
>>> Cheers
>>> Markus
>>>> Am 06.04.2016 um 13:31 schrieb Lars Vogel <lars.vogel@xxxxxxxxxxx>:
>>>>
>>>> Hi Markus,
>>>>
>>>> you can also see
>>>> http://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#eclipsecontribution_usersetup
>>>> for the Gerrit setup.
>>>>
>>>> Best regards, Lars
>>>>
>>>> On Wed, Apr 6, 2016 at 11:04 AM, Daniel Megert <daniel_megert@xxxxxxxxxx> wrote:
>>>>> Markus,
>>>>>
>>>>> https://wiki.eclipse.org/JDT_UI/How_to_Contribute#Provide_a_contribution_using_Gerritexplains
>>>>> it.
>>>>>
>>>>> Communication usually happens directly in the bug reports and the Gerrit
>>>>> reviews.
>>>>>
>>>>> Dani
>>>>>
>>>>>
>>>>>
>>>>> From:        Markus Oley <markus.oley@xxxxxxxxxxxxxx>
>>>>> To:        "Eclipse JDT UI developers list." <jdt-ui-dev@xxxxxxxxxxx>
>>>>> Date:        06.04.2016 10:56
>>>>> Subject:        Re: [jdt-ui-dev] First contribution help
>>>>>
>>>>> Sent by:        jdt-ui-dev-bounces@xxxxxxxxxxx
>>>>> ________________________________
>>>>>
>>>>>
>>>>>
>>>>> Hi Dani,
>>>>>
>>>>> thanks for your answer, I don't know much about the eclipse process itself.
>>>>> So not knowing what is your communication medium, I now added a comment on
>>>>> the bug waiting for Markus to answer.
>>>>>
>>>>> But again, I don't understand the things shown in the docu about
>>>>> contributing with gerrit.
>>>>> I have a user account and I have a valid CLA so far, I can log onto gerrit
>>>>> server.
>>>>>
>>>>> What do I have to do before pushing my things to git?
>>>>>
>>>>> What does "Select a date for project committers to update their repo URLs"
>>>>> mean? Where should I select what date?
>>>>> What does "Choose one of the two options:
>>>>>
>>>>> I want project committers use Gerrit code review exclusively for my project.
>>>>> Everything must be reviewed -- no direct access to the main repo should be
>>>>> available.
>>>>> I want project committers to be able to bypass the Gerrit code review system
>>>>> and push changes directly to the git repo. " mean?
>>>>>
>>>>> Where should I select these options?
>>>>>
>>>>> Sorry for asking maybe obvious questions - but I'm new to gerrit. Perhaps
>>>>> you can recommend me additional docu to get familiar with your processes?
>>>>>
>>>>> Thanks so far,
>>>>>
>>>>> Cheers
>>>>> Markus
>>>>>
>>>>>
>>>>> 2016-04-06 9:41 GMT+02:00 Daniel Megert <daniel_megert@xxxxxxxxxx>:
>>>>> Hi Markus
>>>>>
>>>>> Take a look at: https://wiki.eclipse.org/JDT_UI/How_to_Contribute
>>>>>
>>>>> Even if there was no activity in that bug for 10 years, it is good practice
>>>>> to ask the current owner, whether it is OK to take the bug. If there's no
>>>>> owner, assign the bug to yourself before working on it. This avoids that two
>>>>> people work on the same bug.
>>>>>
>>>>> Dani
>>>>>
>>>>>
>>>>>
>>>>> From:        Markus Oley <markus.oley@xxxxxxxxxxxxxx>
>>>>> To:        "Eclipse JDT UI developers list." <jdt-ui-dev@xxxxxxxxxxx>
>>>>> Date:        05.04.2016 22:01
>>>>> Subject:        [jdt-ui-dev] First contribution help
>>>>> Sent by:        jdt-ui-dev-bounces@xxxxxxxxxxx
>>>>> ________________________________
>>>>>
>>>>>
>>>>>
>>>>> Hi,
>>>>>
>>>>> I want to start contributing to jdt ui and started by fixing an very very
>>>>> easy bug:
>>>>>
>>>>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=138952
>>>>>
>>>>> I have written a test and a very simple fix, now I want to create a
>>>>> contribution.
>>>>>
>>>>> Reading https://wiki.eclipse.org/GerritI have seen, that I should Ask my
>>>>> project lead to +1 the request.
>>>>> If this voting is necessary, can you please do and tell me what to do next?
>>>>>
>>>>> Select a date for project committers to update their repo URLs
>>>>> Choose one of the two options:
>>>>>
>>>>> I don’t understand..?
>>>>>
>>>>> Any help welcome
>>>>> Cheers
>>>>> Markus
>>>>>
>>>>> _______________________________________________
>>>>> jdt-ui-dev mailing list
>>>>> jdt-ui-dev@xxxxxxxxxxx
>>>>> To change your delivery options, retrieve your password, or unsubscribe from
>>>>> this list, visit
>>>>> https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jdt-ui-dev mailing list
>>>>> jdt-ui-dev@xxxxxxxxxxx
>>>>> To change your delivery options, retrieve your password, or unsubscribe from
>>>>> this list, visit
>>>>> https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Markus Oley
>>>>> Hch. Taubenreuther Str. 25
>>>>> 95361 Kulmbach
>>>>> Tel:    0 92 21 / 87 78 88
>>>>> Mobil: 01 52 / 23 67 63 10
>>>>> _______________________________________________
>>>>> jdt-ui-dev mailing list
>>>>> jdt-ui-dev@xxxxxxxxxxx
>>>>> To change your delivery options, retrieve your password, or unsubscribe from
>>>>> this list, visit
>>>>> https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> jdt-ui-dev mailing list
>>>>> jdt-ui-dev@xxxxxxxxxxx
>>>>> To change your delivery options, retrieve your password, or unsubscribe from
>>>>> this list, visit
>>>>> https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
>>>>
>>>>
>>>>
>>>> --
>>>> Eclipse Platform UI and e4 project co-lead
>>>> CEO vogella GmbH
>>>>
>>>> Haindaalwisch 17a, 22395 Hamburg
>>>> Amtsgericht Hamburg: HRB 127058
>>>> Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
>>>> USt-IdNr.: DE284122352
>>>> Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
>>>> _______________________________________________
>>>> jdt-ui-dev mailing list
>>>> jdt-ui-dev@xxxxxxxxxxx
>>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>>> https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
>>>
>>> _______________________________________________
>>> jdt-ui-dev mailing list
>>> jdt-ui-dev@xxxxxxxxxxx
>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>> https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
>>
>>
>>
>> --
>> Eclipse Platform UI and e4 project co-lead
>> CEO vogella GmbH
>>
>> Haindaalwisch 17a, 22395 Hamburg
>> Amtsgericht Hamburg: HRB 127058
>> Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
>> USt-IdNr.: DE284122352
>> Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com
>> _______________________________________________
>> jdt-ui-dev mailing list
>> jdt-ui-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev
>
> _______________________________________________
> jdt-ui-dev mailing list
> jdt-ui-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/jdt-ui-dev



-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com

Back to the top