| Re: [jdt-dev] About Y-Builds (was Re: 4.35 Y-Build: Y20250111-1000 - BUILD FAILED) |
On Mon, Jan 20, 2025 at 1:31 PM Stephan Herrmann via jdt-dev <jdt-dev@xxxxxxxxxxx> wrote:
Are you proposing our implementation should capture the full history of every feature that once was a preview feature, perhaps in several iterations? So when there is a change between previews or between preview and final version, JDT should still mimic each of the preliminary variants?
That is only if we want to easily distinguish preview feature tor version N vs preview feature for N+1. But if this is no needed, then we can probably skip this extra step.
As per the very nature of preview features we MUST ensure that they are only ever enabled for the correct release version.
But if it becomes desirable and helpful to keep track of which compiler version make a feature available as preview vs which one makes it a regular feature, replacing a boolean by an integer in a dozen of enums, and refactoing isPreview() so that is becomes isPreview(int targetVersion) and adopting it in its 2 consumers is not something that seems too difficult.
You're only looking at the trivial part, but you miss the tons of locations that query this data. With your proposal we would never be able to remove any preview checks of features that have long matured, and we would even need separate checks for repeated previews with changes between them.
am I missing anything?