Hi all,
GitHub supports a number of advanced branch protection options. I think we should ask the Eclipse webmaster team to configure these branch protection settings, so we can take full advantage of the features provides by GitHub.
Therefore, I would like to propose to use the following branch protection settings for the master branch. Please also note the comments under the screenshot.
A few notes:
- Require pull request reviews before merging
- This is set to 2 (although we require 3 votes for a pull request), because in many cases pull requests are created by committers which implies one +1 vote. So we technically enforce only 2 approvals although we may need 3 approvals if the pull request is created by someone who is not a committer.
- Dismiss stale pull request approvals when new commits are pushed
- I really think that setting this option is a good idea. Committers having approved a PR should have a another look at the changes if commits were added. This is of course more review work, but absolutely makes sense.
- Require branches to be up to date before merging
- I disabled this option because it would require ALL pull requests to be rebased after a new commit on master has been added. This is too much work and not worth the effort.
Please let me now your thoughts.
Christian
