No, I don’t have any settings tab available.
Peter
From: january-dev-bounces@xxxxxxxxxxx [mailto:january-dev-bounces@xxxxxxxxxxx]
On Behalf Of Jonah Graham
Sent: 09 March 2017 12:56
To: january developer discussions <january-dev@xxxxxxxxxxx>
Subject: Re: [january-dev] Master not protected
OK, Fred @ Eclipse has made the changes now, master should be protected.
Matt, is this screenshot on your log-in to eclipse/scanning? I can't access Settings myself. Peter do you have access to Settings?
On 8 March 2017 at 12:58, <Matt.Gerring@xxxxxxxxxxxxx> wrote:
The settings are here:
From:
january-dev-bounces@xxxxxxxxxxx [mailto:january-dev-bounces@xxxxxxxxxxx]
On Behalf Of Matthew Gerring
Sent: 08 March 2017 11:55
To: january developer discussions
Subject: Re: [january-dev] Master not protected
I suggest:
Committer - merge when tests and review pass
Others - create pull request from fork to be merged by committer once tests and review pass
No-one - merge if tests don't pass.
This is same as gerrit workflow used on other eclipse projects.
On 8 March 2017 at 11:51, Jonah Graham <jonah@xxxxxxxxxxxxxxxx> wrote:
Hi,
>You can see below that I could merge the comment with no checks passed if I chose.
Of course you can, you are a committer. That is part of the rights and responsibilities of a committer.
Obviously it sounds like you want to change this policy? What are other's thoughts on it. Should we have a vote on this?
Hello,
Master is still not protected. To do this go into ‘Settings’ and force the checks to pass before allowing a merge. You can see below that I could merge the comment with no checks
passed if I chose.
Matt
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee
please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
_______________________________________________
january-dev mailing list
january-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/january-dev
_______________________________________________
january-dev mailing list
january-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/january-dev
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt
by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
_______________________________________________
january-dev mailing list
january-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/january-dev
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
|
