Re: [january-dev] About to create CQ for initial contribution

[<Peter.Chang@xxxxxxxxxxxxx>]

Hi Jonah,

That's a fine plan. I may branch off that to add more changes but we can merge those later.

Regards,
 Peter


-----Original Message-----
From: january-dev-bounces@xxxxxxxxxxx [mailto:january-dev-bounces@xxxxxxxxxxx] On Behalf Of Jonah Graham
Sent: 06 July 2016 22:30
To: january developer discussions <january-dev@xxxxxxxxxxx>
Subject: [january-dev] About to create CQ for initial contribution

Hi January devs,

I think we now have the three parts of our initial contribution ready to go. I think we are ready to start the CQ process.

The initial contribution will be the org.eclipse.january.* bundles from the ICE, Dawnsci and EAVP repositories. These are the git commits I will be using.

https://github.com/eclipse/dawnsci/commit/d46a644e0443b4c1ffe37760af86283210372812
https://github.com/eclipse/ice/commit/66b4c63f8cf0812c13d30af45ec3851a3c4b9be3
https://github.com/eclipse/eavp/commit/8c60bc100ddc12ab5441a381ea0886fd66ee0361

The only caveats are that for EAVP I need to remove some files.
- There are some presumably accidentally committed files, I created
https://github.com/eclipse/eavp/pull/74 for that
- The antlr patch needs to be removed from the CQ zip:
https://github.com/eclipse/eavp/blob/8c60bc100ddc12ab5441a381ea0886fd66ee0361/org.eclipse.january.geometry.model/.antlr-generator-3.2.0-patch.jar

If these can be addressed, then I will be able to have a cleaner correspondence between code in the CQ and git commits.

For sanity and traceability, I think it is important that these git commit ids are long lived, or at least long enough until the initial contribution is approved and the code is moved across. By doing it that way, applying any changes made between the initial contribution and the approval will be a lot easier.

How does the above sound as a plan? I will raise the CQ tomorrow

Thank you everyone for your hard work on getting January ready! I think we are nearly there.

Jonah

~~~
Jonah Graham
Kichwa Coders Ltd.
www.kichwacoders.com
_______________________________________________
january-dev mailing list
january-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/january-dev

-- 
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. 
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom