[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [jakartaee-tck-dev] [External] : Re: Official Annotations 3.0.0 TCK?
|
Hi,
On 18.03.2024 16:11, Arjan Tijms wrote:
Hi
I did look at the Common Annotations TCK, and it’s basically only a
signature test:
https://github.com/jakartaee/common-annotations-api/blob/master/tck/pom.xml <https://urldefense.com/v3/__https://github.com/jakartaee/common-annotations-api/blob/master/tck/pom.xml__;!!ACWV5N9M2RV99hQ!PG-AI0ss5Tjq0NCjCgrUxIHvca0Nq6TNlhIteZMQYQ7R-oPVrpR_H6kMYbCfu9Xi5cqbtGOUr56sbj0gKOuAhco36ySd$> >
Though I have to say that this test class doesn’t look universal to me:
https://github.com/jakartaee/common-annotations-api/blob/master/tck/src/main/java/ee/jakarta/tck/annotations/signaturetest/CAJSigTestIT.java <https://urldefense.com/v3/__https://github.com/jakartaee/common-annotations-api/blob/master/tck/src/main/java/ee/jakarta/tck/annotations/signaturetest/CAJSigTestIT.java__;!!ACWV5N9M2RV99hQ!PG-AI0ss5Tjq0NCjCgrUxIHvca0Nq6TNlhIteZMQYQ7R-oPVrpR_H6kMYbCfu9Xi5cqbtGOUr56sbj0gKOuAhUgh0iw9$>
Would it not be easier if the runner pom just:
1. Downloaded the GlassFish distribution used for testing > 2. Defined a property to point to the commons API jar file within the
just downloaded GlassFish
3. Run the Signature test plugin with the previously generated sig file
and the just defined property as input?
What if in the spec-tck one sets the runner pom's parent to sth like
jakartaee.tck:tck-test-runner, defines run-sigtests and possibly also
run-sigtests-in-container execution, a property or two pointing to sig
file and a jar name or classpath and is done with all the work on this
instead? The parent could also provide profile(s) to download different
runtimes, not just glassfish.
This would certainly lead to less people required to maintain the stuff,
consistent dev as well as end-user experience, less copy&paste errors,
faster & easier adoption of (changing) platform requirements - and open
a possibility to automate parent updates in consuming projects,
including ca-tck one.
The requirement here would be for someone - platform? owner of the
sigtest plugin? - to provide such "common" parent runner
Maybe also clearer to the generation of the signature is a
separate module, so that's clear this is not part of the TCK test, but
something the project maintainers only do once? For that the project
could perhaps just copy this one and adjust for the CA coordinates:
https://github.com/jakartaee/faces/blob/4.1/tck/faces-signaturegen/pom.xml <https://urldefense.com/v3/__https://github.com/jakartaee/faces/blob/4.1/tck/faces-signaturegen/pom.xml__;!!ACWV5N9M2RV99hQ!PG-AI0ss5Tjq0NCjCgrUxIHvca0Nq6TNlhIteZMQYQ7R-oPVrpR_H6kMYbCfu9Xi5cqbtGOUr56sbj0gKOuAhTgf9C48$>
I'm not a fan of copy&paste programming but I can understand sometimes
there is no way around it and it is the most simple and fastest way to
move forward. Is it the best one? No, I do not think so.
thanks,
--lukas
Kind regards,
Arjan Tijms
On Mon, 11 Mar 2024 at 17:32, Arjan Tijms <arjan.tijms@xxxxxxxxxxx
<mailto:arjan.tijms@xxxxxxxxxxx>> wrote:
Hi,
Thanks everyone for the answers!
Kind regards,
Arjan Tijms
On Mon, 11 Mar 2024 at 17:07, Alwin Joseph <alwin.joseph@xxxxxxxxxx
<mailto:alwin.joseph@xxxxxxxxxx>> wrote:
+Lukas ____
__ __
More userguide changes were made after the TCK was migrated to
https://github.com/jakartaee/common-annotations-api/tree/master/tck <https://urldefense.com/v3/__https://github.com/jakartaee/common-annotations-api/tree/master/tck__;!!ACWV5N9M2RV99hQ!PG-AI0ss5Tjq0NCjCgrUxIHvca0Nq6TNlhIteZMQYQ7R-oPVrpR_H6kMYbCfu9Xi5cqbtGOUr56sbj0gKOuAhRHcagsy$> .____
__ __
Any further changes can be made to the TCK in the above
specification project based on the review.____
__ __
We will be removing the annotations TCK sources from
https://github.com/jakartaee/platform-tck/tree/tckrefactor
<https://urldefense.com/v3/__https://github.com/jakartaee/platform-tck/tree/tckrefactor__;!!ACWV5N9M2RV99hQ!PG-AI0ss5Tjq0NCjCgrUxIHvca0Nq6TNlhIteZMQYQ7R-oPVrpR_H6kMYbCfu9Xi5cqbtGOUr56sbj0gKOuAhY5S9YJP$> soon.____
__ __
Regards,
Alwin____
__ __
*From: *Scott Marlow <smarlow@xxxxxxxxxx
<mailto:smarlow@xxxxxxxxxx>>
*Date: *Monday, 11 March 2024 at 9:15 PM
*To: *Arjan Tijms <arjan.tijms@xxxxxxxxxxx
<mailto:arjan.tijms@xxxxxxxxxxx>>
*Cc: *jakartaee-tck developer discussions
<jakartaee-tck-dev@xxxxxxxxxxx
<mailto:jakartaee-tck-dev@xxxxxxxxxxx>>, Alwin Joseph
<alwin.joseph@xxxxxxxxxx <mailto:alwin.joseph@xxxxxxxxxx>>,
Gurunandan Rao <gurunandan.rao@xxxxxxxxxx
<mailto:gurunandan.rao@xxxxxxxxxx>>, Edward Burns
<Edward.Burns@xxxxxxxxxxxxx
<mailto:Edward.Burns@xxxxxxxxxxxxx>>, Ivar Grimstad
<ivar.grimstad@xxxxxxxxxxxxxxxxxxxxxx
<mailto:ivar.grimstad@xxxxxxxxxxxxxxxxxxxxxx>>
*Subject: *[External] : Re: Official Annotations 3.0.0 TCK?____
__ __
__ __
__ __
On Mon, Mar 11, 2024 at 10:28 AM Arjan Tijms
<arjan.tijms@xxxxxxxxxxx <mailto:arjan.tijms@xxxxxxxxxxx>>
wrote:____
Hi, ____
__ __
Just wondering, is
https://ci.eclipse.org/jakartaee-tck/job/11/job/standalone-tck/job/eftl-annotations-standalonetck-build/ <https://urldefense.com/v3/__https:/ci.eclipse.org/jakartaee-tck/job/11/job/standalone-tck/job/eftl-annotations-standalonetck-build/__;!!ACWV5N9M2RV99hQ!NM5FNkSpfpRANEI7WQi05qwKIWl1Gx0KfG550wNyCgBsXwmlLjim5ePA4ktbp3l8Sk-elZ8qS_KVfbjkVfg$> the official TCK to ratify Jakarta Annotations 3.0.0 for Jakarta EE 11?____
__ __
Is it fully done?____
__ __
No, the documentation needs changes which is mentioned in
https://github.com/jakartaee/platform-tck/pull/1222
<https://urldefense.com/v3/__https:/github.com/jakartaee/platform-tck/pull/1222__;!!ACWV5N9M2RV99hQ!NM5FNkSpfpRANEI7WQi05qwKIWl1Gx0KfG550wNyCgBsXwmlLjim5ePA4ktbp3l8Sk-elZ8qS_KVP_sKcwc$>____
____
__ __
Kind regards,____
Arjan Tijms____
